Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish univeral (Python2 / Python 3) wheels #1423

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Mar 9, 2023

Releases on PyPI currently have a filename such as:
pymodbus-3.2.0-py2.py3-none-any.whl

Per PEP425, the compatibility tags py2 and py3 indicate the package is compatible with Python2 and Python3.

This PR drops Python2, which was accidentally left in.

setup.cfg Show resolved Hide resolved
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks (I will just rebase dev, to get a clean CI)

@janiversen janiversen merged commit a7d3cba into dev Mar 10, 2023
@janiversen janiversen deleted the py2-wheel branch March 10, 2023 15:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants