Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nosec #1379

Merged
merged 5 commits into from
Feb 21, 2023
Merged

remove nosec #1379

merged 5 commits into from
Feb 21, 2023

Conversation

janiversen
Copy link
Collaborator

nosec is referring to a linter we no longer use.

@alexrudd2
Copy link
Collaborator

Ahaha, I was preparing to introduce ruff which would include bandit again...

@janiversen
Copy link
Collaborator Author

I am not removing bandit (which also uses nosec) we removed another tool a long time ago, because it had too many false positives.

Adding ruff is a nice plan !

@janiversen
Copy link
Collaborator Author

btw there are a few places where bandit complain and I intent to correct those with this PR.

Correcting is a lot better than disabling checks.

@janiversen janiversen merged commit 720fc9d into dev Feb 21, 2023
@janiversen janiversen deleted the remove_nosec branch February 21, 2023 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants