Fix more typing issues

[alexrudd2]

I'm trying out mypy. This is still a WIP, although you can merge early if you want.

What should we do with implicit optional types? https://adamj.eu/tech/2022/10/18/python-type-hints-implicit-optional-types/

[janiversen]

I look forward to having mypy activity….at the very least for the api. Thanks a lot for taking this on.

I prefer to allow “implicit option types” that is writing “text: str = None” is allowed. Forcing “text: Optional[str, None] = None” is just a real PITA.

I am happy to review your stuff whenever you feel you have reached a level, where you want it merged. Just put it in review, and I will review/approve fast.

[jamesbraza]

@janiversen fwiw, even though Optional is a bit ugly and expands signatures, it's recommended in PEP 484. The authors actually changed their minds on the implicit typing.

https://peps.python.org/pep-0484/#union-types

A past version of this PEP allowed type checkers to assume an optional type when the default value is None

This is no longer the recommended behavior. Type checkers should move towards requiring the optional type to be made explicit.

[janiversen]

I know that it is recommended, but it not demanded. We support 3.8+ so for us it would be a lot of useless typing, which do not make the code better or more readable.

Please remark this is just my opinion and in no way a demand.

[janiversen]

I think we should merge this soon to avoid having clashes with other pull requests. Making a merge after every 10-20 files sounds good to me.

It is a big job you have taken on, but it looks very very nice.

[alexrudd2]

I think we should merge this soon to avoid having clashes with other pull requests. Making a merge after every 10-20 files sounds good to me.

It is a big job you have taken on, but it looks very very nice.

OK, it should be ready to merge. mypy errors go from 111 -> 94 with this PR.

[janiversen]

A very good start. I did not know that typer() converted, thanks for testing it.

[janiversen]

I merged the first part….looks very good to me.

Looking forward to see next part.