Return None for broadcast. (#1987)

pymodbus-dev · Feb 9, 2024 · a4184f1 · a4184f1
1 parent 7f469d5
commit a4184f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pymodbus/client/base.py b/pymodbus/client/base.py
@@ -161,7 +161,7 @@ async def async_execute(self, request=None) -> ModbusResponse:
             if not count or not self.no_resend_on_retry:
                 self.transport_send(packet)
             if self.broadcast_enable and not request.slave_id:
-                resp = b"Broadcast write sent - no response expected"
+                resp = None
                 break
             try:
                 resp = await asyncio.wait_for(

diff --git a/test/sub_client/test_client.py b/test/sub_client/test_client.py
@@ -424,8 +424,7 @@ async def test_client_execute_broadcast():
     transport = MockTransport(base, request)
     base.connection_made(transport=transport)
 
-    response = await base.async_execute(request)
-    assert  response == b'Broadcast write sent - no response expected'
+    assert not await base.async_execute(request)
 
 async def test_client_protocol_retry():
     """Test the client protocol execute method with retries."""