Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: single top level meson.build, add NotificationTester and SequenceTester #44

Merged
merged 44 commits into from
Mar 19, 2025

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Mar 17, 2025

the whole symlinking of MMDevice is problematic, particularly cross-platform... so this PR goes with the recommended (?) approach of having a single top level meson.build that manages all subdirectories

it does some significant cleanup of unneeded files, and also adds NotificationTester and SequenceTester (boost installed at system level, and msgpack installed via wrap)

@tlambert03 tlambert03 changed the title single top level meson.build single top level meson.build, add NotificationTester and SequenceTester Mar 17, 2025
@tlambert03 tlambert03 changed the title single top level meson.build, add NotificationTester and SequenceTester feat: single top level meson.build, add NotificationTester and SequenceTester Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 667 lines in your changes missing coverage. Please review.

Project coverage is 16.22%. Comparing base (418bf39) to head (0fa69f4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Adapters/NotificationTester/NotificationTester.cpp 0.00% 409 Missing and 17 partials ⚠️
...s/DeviceAdapters/NotificationTester/ProcessModel.h 0.00% 153 Missing and 8 partials ⚠️
...eviceAdapters/NotificationTester/DelayedNotifier.h 0.00% 77 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   24.08%   16.22%   -7.86%     
==========================================
  Files          90      129      +39     
  Lines        6710    20290   +13580     
  Branches     3516     8435    +4919     
==========================================
+ Hits         1616     3292    +1676     
- Misses       3773    14625   +10852     
- Partials     1321     2373    +1052     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 1d9646e into pymmcore-plus:main Mar 19, 2025
14 of 16 checks passed
@tlambert03 tlambert03 deleted the simpler-build branch March 19, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant