Skip to content

Changed pt=pt to pt_lib = None to avoid showing full module path in docs #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Changed pt=pt to pt_lib = None to avoid showing full module path in docs #992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09f7678
Changed pt=pt to pt_lib = None to avoid showing full module path in docs
radiokosmos Sep 1, 2024
55fdcd2
Changed pt to pt_lib inside calculate_lift_measurements_from_curve
radiokosmos Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pymc_marketing/mmm/lift_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def calculate_lift_measurements_from_curve(
x_before: npt.NDArray[np.float64],
x_after: npt.NDArray[np.float64],
saturation_curve: Callable[[npt.NDArray[np.float64]], npt.NDArray[np.float64]],
pt=pt,
pt_lib=None,
) -> npt.NDArray[np.float64]:
"""Calculate the lift measurements at two spends.

Expand All @@ -105,16 +105,20 @@ def calculate_lift_measurements_from_curve(
Array of x after the change.
saturation_curve : Callable[[npt.NDArray[float]], npt.NDArray[float]]
Function that takes spend and returns saturation.
pt : tensor module, optional. Default is pytensor.tensor.
pt_lib : tensor module, optional. Default is pytensor.tensor.

Returns
-------
npt.NDArray[float]
Array of lift measurements based on a given saturation curve

"""
return pt.diff(
saturation_curve(pt.stack([x_before, x_after])),
# setting default pl_lib to pytensor.tensor
if pt_lib is None:
pt_lib = pt

return pt_lib.diff(
saturation_curve(pt_lib.stack([x_before, x_after])),
axis=0,
).flatten()

Expand Down