Fixing fixed_beta bug adding new test for nested_logit #2015
+839
−762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
docs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 93.89% 93.95% +0.05%
==========================================
Files 67 67
Lines 9221 9228 +7
==========================================
+ Hits 8658 8670 +12
+ Misses 563 558 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
juanitorduz
approved these changes
Oct 19, 2025
|
Should we cut a new release? |
We probably do it today! We are solving some other issue in https://github.com/pymc-labs/pymc-marketing/actions/runs/18628039054/job/53108823321?pr=2010 This will unlock 2 PRs waiting for merge :) after it. we can do release. |
TeemuSailynoja
pushed a commit
that referenced
this pull request
Oct 20, 2025
* fixing fixed beta bug adding new test for consumer choice Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> * fix linting Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> * shorten line length Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> * running ruff Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> * running ruff format Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> * adding beta_fixed coefficients in notebook Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> * text edit to force job re-run Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com> --------- Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing bug on nested logit when using pymc 5.26 and ensuring parameter identification holds.
Related Issue
Following discussion here: #2011
I've opened a clean branch from main to fix the bug and test parameter identification. I've added a new test and demonstrated the counterfactual removal strategy in the nested logit notebook.
Fix was basically the addition @juanitorduz made but i had keep the dimensions as i had them.
📚 Documentation preview 📚: https://pymc-marketing--2015.org.readthedocs.build/en/2015/