Skip to content

Fix LinearTrend changepoints in plot_curve method #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2025

Conversation

gdeleva
Copy link
Contributor

@gdeleva gdeleva commented Jun 7, 2025

We corrected the formula for the change point time positions in the docstrings and aligned the vertical lines in the plot_curve function with the actual change point positions.

Description

Correct the formula of the position of the change points;
Align the vertical lines of plot_curve to the position of the change points.

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1739.org.readthedocs.build/en/1739/

@github-actions github-actions bot added MMM model components Related to the various model components labels Jun 7, 2025
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (4eecb28) to head (7fb6781).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1739   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          60       60           
  Lines        6780     6780           
=======================================
  Hits         6210     6210           
  Misses        570      570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@williambdean
Copy link
Contributor

Thanks for the PR @gdeleva!

Copy link
Contributor

@williambdean williambdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@williambdean williambdean added the bug Something isn't working label Jun 7, 2025
@williambdean williambdean changed the title Clarify definition of change points of LinearTrend and fix plot_curve accordingly Fix LinearTrend changepoints in plot_curve method Jun 7, 2025
@williambdean williambdean merged commit 33dc122 into pymc-labs:main Jun 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MMM model components Related to the various model components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear trend Changepoints Misaligned in Plot
2 participants