Skip to content

multidimensional MMM initialization validation #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 8, 2025

Conversation

IlanDanial
Copy link
Contributor

@IlanDanial IlanDanial commented May 29, 2025

Description

Added the fixes put in the review where desired attributes can now be set to none and got rid of dict fixer.

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1725.org.readthedocs.build/en/1725/

@github-actions github-actions bot added MMM tests enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package labels May 29, 2025
@IlanDanial
Copy link
Contributor Author

Sorry had a hard time adding to my last pull main changes are on the following lines
tests/mmm/test_multidimensional.py 904-919
pymc_marketing/mmm/multidimensional.py 147-160
And I deleted which was 185-187
for side in ("channel", "target"):
if side in scaling and isinstance(scaling[side], dict):
scaling[side].setdefault("dims", self.dims)

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (33dc122) to head (0b8f36e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          60       60           
  Lines        6780     6782    +2     
=======================================
+ Hits         6210     6212    +2     
  Misses        570      570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanitorduz
Copy link
Collaborator

hi @IlanDanial , is this the same as in #1721 ? Shall we close #1721 then ?

@IlanDanial
Copy link
Contributor Author

IlanDanial commented Jun 1, 2025

Yes it is the same as 1721 just closed it sorry for the confusion @juanitorduz

@juanitorduz juanitorduz self-requested a review June 4, 2025 13:18
@juanitorduz
Copy link
Collaborator

Thank you @IlanDanial !

@juanitorduz juanitorduz merged commit 81503f5 into pymc-labs:main Jun 8, 2025
32 checks passed
@williambdean williambdean changed the title Valid init pydantic multidimensional MMM initialization validation Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pydantic validation multidimensional MMM init
3 participants