-
Notifications
You must be signed in to change notification settings - Fork 291
multidimensional MMM initialization validation #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the same as other classes and added tests to confirm its functionality
…antic to update PR and adress issues brought up in review
Sorry had a hard time adding to my last pull main changes are on the following lines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 60 60
Lines 6780 6782 +2
=======================================
+ Hits 6210 6212 +2
Misses 570 570 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi @IlanDanial , is this the same as in #1721 ? Shall we close #1721 then ? |
Yes it is the same as 1721 just closed it sorry for the confusion @juanitorduz |
Thank you @IlanDanial ! |
Description
Added the fixes put in the review where desired attributes can now be set to none and got rid of dict fixer.
Related Issue
Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1725.org.readthedocs.build/en/1725/