Allow rebuilding graphs when output type depends on input values #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
3 times, most recently
from
c956086 to
86c6ac0
Compare
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
86c6ac0 to
2c429c0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 156 156
Lines 45397 45400 +3
Branches 11106 11104 -2
=======================================
+ Hits 36497 36502 +5
+ Misses 6694 6691 -3
- Partials 2206 2207 +1
|
ferrine
reviewed
May 24, 2023
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
2c429c0 to
54b4b94
Compare
ricardoV94
changed the title
ricardoV94
changed the title
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
54b4b94 to
2a5b419
Compare
|
I test that the Shape Op is present even when static shapes are present. |
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
2 times, most recently
from
306f531 to
d15f8ca
Compare
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
d15f8ca to
214a447
Compare
ferrine
reviewed
May 25, 2023
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
214a447 to
24c20dc
Compare
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
24c20dc to
e0febc4
Compare
ferrine
requested changes
Jun 21, 2023
| for i, (curr, new) in enumerate(zip(self.inputs, new_inputs)): | ||
| if curr.type != new.type: | ||
| if (curr.type != new.type) or output_type_depends_on_input_value: |
There was a problem hiding this comment.
Not super clear the branching logic from the outsider glance, can you please add comments that explain what exactly happens in each branch?
These nodes must always be rebuilt in non-strict mode
ricardoV94
force-pushed
the
keep_shape_dependencies
branch
from
e0febc4 to
0522b2a
Compare
ferrine
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #254
Closes #253