Do not coerce gradients to TensorVariable #1685
Merged
+27
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
approved these changes
Oct 28, 2025
Member
jessegrabowski
left a comment
jessegrabowski
left a comment
There was a problem hiding this comment.
Looks good, but mypy is failing.
How did this come up?
Member
Author
I was trying to use it in the loop autodiff example. Ended up not wanting it but fixed it anyway |
This could cause spurious disconnected errors, because the tensorified variable was not in the graph of the cost
jessegrabowski
force-pushed
the
gradient_of_scalars_bug
branch
from
4fa414c to
42f1367
Compare
Member
|
This should be fine now, lmk if you object to the mypy fix. The same thing came up in #1828 . If we use |
ricardoV94
commented
Jan 9, 2026
| _f: list[Variable] = [pytensor.tensor.as_tensor_variable(f)] | ||
| else: | ||
| _f = [pytensor.tensor.as_tensor_variable(x) for x in f] | ||
| if not isinstance(eval_points, Sequence): |
Member
Author
There was a problem hiding this comment.
Annoying thing is that Sequence includes str, so it's not always the thing we want. Fine here
ricardoV94
added a commit
to ricardoV94/pytensor
that referenced
this pull request
Jan 11, 2026
* Do not coerce gradients to TensorVariable This could cause spurious disconnected errors, because the tensorified variable was not in the graph of the cost * Type-consistent checks --------- Co-authored-by: jessegrabowski <jessegrabowski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could cause spurious disconnected errors, because the tensorified variable was not in the graph of the cost
📚 Documentation preview 📚: https://pytensor--1685.org.readthedocs.build/en/1685/