-
Notifications
You must be signed in to change notification settings - Fork 136
Add xtensor docs #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add xtensor docs #1504
Conversation
a703ae4
to
d472f62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than fixing the environment everything looks good, there are a couple other things that could be done but also feel free to merge with just fixing the environment
We get a lot of |
A lot of? For the pages we have added or other ones? This means those pages are not reachable through the navbar+sidebar navigation. Unless there are referenced in another page or the users magically know their url they won't be able to reach them. Ideally there wouldn't be toctree warnings, if we really want to have pages that are not on the toctree and are only referenced inline somewhere else they should include |
6939ee0
to
158ee2a
Compare
Okay not a lot:
Some are the ones I removed that are tracked in #1512 the others are dot, concat which is odd, and the xtensor.type, that I mentioned is coming up blank
|
The ones in the generated folder is because they were automatically generated by autosummary at some point when |
If you are checking out the branch already feel free to push the removal of readme.md |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (56.72%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
==========================================
- Coverage 81.98% 81.82% -0.16%
==========================================
Files 231 231
Lines 52274 52467 +193
Branches 9206 9338 +132
==========================================
+ Hits 42856 42931 +75
+ Misses 7106 7095 -11
- Partials 2312 2441 +129
🚀 New features to boost your workflow:
|
It was |
That seems like a very fun afternoon xD |
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
@OriolAbril do you want to take a last look before we merge? |
Closes #1502
📚 Documentation preview 📚: https://pytensor--1504.org.readthedocs.build/en/1504/