Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Moving SGFS, CSG from pymc3 to pymc3-experimental #1

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Moving SGFS, CSG from pymc3 to pymc3-experimental #1

merged 3 commits into from
Mar 4, 2019

Conversation

vbsinha
Copy link
Contributor

@vbsinha vbsinha commented Mar 3, 2019

This work is related to (#3353). The corresponding PR in pymc3 repo is (#3391). Here is the summary of the changes:

  1. Moved sgmcmc.py to this repo.
  2. Moved the test file: test_sgfs.py to this repo.
  3. Moved three notebooks using SGFS and CSG to this repo.

The file test_sgfs can be run by python test_sgfs.py.

@twiecki Could you please review and point out if there are any issues?

@junpenglao
Copy link
Member

junpenglao commented Mar 3, 2019

You should copy the TravisCI setup from PyMC3 to here so that the code will get tested.

@vbsinha
Copy link
Contributor Author

vbsinha commented Mar 3, 2019

In case we create an independent library as @twiecki has suggested or we need the TravisCI setup as @junpenglao has suggested, we need to create a proper directory structure and write setup.py etc. At the moment I have just placed the newly added python files in the main directory which will have to move when the directory structure is organized. The notebooks do not import SGFS and CSG from the python files instead they do it from original pymc3. This too would need to change. Please guide me how should I continue.

@twiecki
Copy link
Member

twiecki commented Mar 3, 2019

@vbsinha Want to set that up (most can be copied from pymc3)? I can merge this and we can do follow up PRs.

@vbsinha
Copy link
Contributor Author

vbsinha commented Mar 4, 2019

@twiecki I would like to try setting things up, following the same directory structure as pymc3. Starting a new PR for this might be a good idea.

@twiecki twiecki merged commit 311f2b9 into pymc-devs:master Mar 4, 2019
@vbsinha vbsinha deleted the Move_SGFS_CSG_to_pymc3_experimental branch March 4, 2019 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants