Bump PyTensor and support numpy>2.0 and Python 3.13 #7688
Merged
+83
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
pytensor_python_bump
branch
2 times, most recently
from
15722b5 to
7721a0d
Compare
ricardoV94
commented
Feb 23, 2025
Comment on lines
-244
to
-245
| @_class_or_instancemethod | ||
| @property |
There was a problem hiding this comment.
Python 3.13 stopped allowing chaining property and classmethods
|
mypy seems to be tripped by new type-hint stuff in numpy? |
ricardoV94
force-pushed
the
pytensor_python_bump
branch
4 times, most recently
from
583489b to
5e5c72e
Compare
ricardoV94
commented
Feb 24, 2025
| @@ -369,7 +369,7 @@ def get_support_shape( | |||
| support_shape_offset = [0] * ndim_supp | |||
| elif isinstance(support_shape_offset, int): | |||
| support_shape_offset = [support_shape_offset] * ndim_supp | |||
| inferred_support_shape: Sequence[int | np.ndarray | Variable] | None = None | |||
| inferred_support_shape: Sequence[int | np.ndarray | TensorVariable] | None = None | |||
There was a problem hiding this comment.
Mypy complains correctly that - is not defined for base Variable classes
ricardoV94
commented
Feb 24, 2025
| if active_dims is None: | ||
| self.active_dims = np.arange(input_dim) | ||
| else: | ||
| self.active_dims = np.asarray(active_dims, int) | ||
|
|
||
| if max(self.active_dims) > self.input_dim: | ||
| if self.active_dims.max() > self.input_dim: |
ricardoV94
commented
Feb 24, 2025
| @@ -876,7 +876,7 @@ def sample_posterior_predictive( | |||
| try: | |||
| with progress: | |||
| task = progress.add_task("Sampling ...", completed=0, total=samples) | |||
| for idx in np.arange(samples): | |||
| for idx in range(samples): | |||
There was a problem hiding this comment.
mypy doesn't like one iterating over arange anymore. Anwyay I don't think that we need to, so I'll let it have its way
ricardoV94
force-pushed
the
pytensor_python_bump
branch
2 times, most recently
from
62a898f to
95cf770
Compare
ricardoV94
force-pushed
the
pytensor_python_bump
branch
2 times, most recently
from
eea3e13 to
8c90429
Compare
|
We seem to have a lingering test failing due to pymc-devs/pytensor#1242 Everything else is green! |
ricardoV94
force-pushed
the
pytensor_python_bump
branch
from
8c90429 to
4dd5dbf
Compare
ricardoV94
changed the title
ricardoV94
force-pushed
the
pytensor_python_bump
branch
2 times, most recently
from
2486a34 to
c69924b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7688 +/- ##
==========================================
- Coverage 92.70% 92.67% -0.04%
==========================================
Files 107 107
Lines 18391 18313 -78
==========================================
- Hits 17050 16971 -79
- Misses 1341 1342 +1
|
|
Can we expose the new |
I would rather not do it here |
jessegrabowski
approved these changes
Feb 26, 2025
twiecki
approved these changes
Feb 26, 2025
maresb
approved these changes
Feb 26, 2025
ricardoV94
force-pushed
the
pytensor_python_bump
branch
from
c69924b to
f509f02
Compare
ricardoV94
force-pushed
the
pytensor_python_bump
branch
from
f509f02 to
be342ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7592
Closes #7551
Closes #7417
📚 Documentation preview 📚: https://pymc--7688.org.readthedocs.build/en/7688/