Fix bug when freezing model with partially observed RVs #7388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Jun 24, 2024
| @@ -1045,7 +1045,7 @@ def constant_fold( | |||
| attempting constant folding, and any old non-shared inputs will not work with | |||
| the returned outputs | |||
| """ | |||
| fg = FunctionGraph(outputs=xs, features=[ShapeFeature()], clone=True) | |||
| fg = FunctionGraph(outputs=xs, features=[ShapeFeature()], copy_inputs=False, clone=True) | |||
There was a problem hiding this comment.
This should be safe, as we can never mutate inputs accidentally (there is no such operation)
aseyboldt
approved these changes
Jun 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7388 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 103 103
Lines 17214 17214
=======================================
Hits 15870 15870
Misses 1344 1344
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was that the
constant_foldcall increate_partially_observed_rvwas cloning the shared variable that defined the dim_length, and therefore it could no longer be replaced by it infreeze_data_and_dimsRelated Issue
freeze_rv_and_dimswithPartiallyObservedRV#7316Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7388.org.readthedocs.build/en/7388/