Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin blackjax to lowest conda-compatible version in CI #7320

Merged
merged 2 commits into from
May 16, 2024
Merged

Pin blackjax to lowest conda-compatible version in CI #7320

merged 2 commits into from
May 16, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 16, 2024 •
edited
Loading

Description

Trying to understand why did blackjax tests start failing if we're pinning everything We were only lower pinning blackjax

conda-forge/jaxlib-feedstock#249

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7320.org.readthedocs.build/en/7320/

@ricardoV94 ricardoV94 changed the title Print installed packages in CI Pin to lowest conda-compatible blackjax version May 16, 2024
@ricardoV94 ricardoV94 requested review from twiecki and junpenglao May 16, 2024 09:23
@ricardoV94 ricardoV94 changed the title Pin to lowest conda-compatible blackjax version Pin blackjax to lowest conda-compatible version in CI May 16, 2024
@ricardoV94 ricardoV94 added jax Github CI/CD no releasenotes Skipped in automatic release notes generation labels May 16, 2024
@ricardoV94
Copy link
Member Author

CI is fixed

@ricardoV94 ricardoV94 mentioned this pull request May 16, 2024
Closed
9 tasks
junpenglao
junpenglao approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@junpenglao junpenglao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer version of JAX is still not on Conda? hmmmm...

@ricardoV94
Copy link
Member Author

newer version of JAX is still not on Conda? hmmmm...

For a while now, see @twiecki issue: conda-forge/jaxlib-feedstock#249

@ricardoV94
Copy link
Member Author

@junpenglao you may want to lower pin jax/jaxlib version in blackjax, since it is no longer compatible with the old clip API

@michaelosthege michaelosthege merged commit 4e8e986 into pymc-devs:main May 16, 2024
20 checks passed
@fonnesbeck fonnesbeck mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpenglao junpenglao junpenglao approved these changes

@michaelosthege michaelosthege michaelosthege approved these changes

@twiecki twiecki twiecki approved these changes

Assignees
No one assigned
Labels
Github CI/CD jax no releasenotes Skipped in automatic release notes generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricardoV94 @twiecki @michaelosthege @junpenglao