Skip to content

Fix wrong ZeroSumNormal logp expression #6872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lucianopaz
Copy link
Member

@lucianopaz lucianopaz commented Aug 21, 2023

Closes #6871

What is this PR about?

This PR fixes the ZeroSumNormal logp expression. It also changes the logp test to to compare the logp to the reference value for points drawn at random in the zero sum manifold and not only at the mode.

Checklist

Bugfixes

  • Fix the logp expression for the ZeroSumNormal distribution

📚 Documentation preview 📚: https://pymc--6872.org.readthedocs.build/en/6872/

@lucianopaz lucianopaz added the bug label Aug 21, 2023
@lucianopaz lucianopaz requested a review from aseyboldt August 21, 2023 08:43
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #6872 (e2ebb80) into main (9ee5d84) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6872      +/-   ##
==========================================
+ Coverage   92.05%   92.07%   +0.01%     
==========================================
  Files          96       96              
  Lines       16445    16446       +1     
==========================================
+ Hits        15139    15143       +4     
+ Misses       1306     1303       -3     
Files Changed Coverage Δ
pymc/distributions/multivariate.py 92.56% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@lucianopaz
Copy link
Member Author

I'll go ahead and merge

@lucianopaz lucianopaz merged commit d659848 into pymc-devs:main Sep 12, 2023
@lucianopaz lucianopaz deleted the iss6871 branch September 12, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ZeroSumNormal has an incorrect logp
2 participants