Fix wrong ZeroSumNormal logp expression #6872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6871
What is this PR about?
This PR fixes the
ZeroSumNormal
logp
expression. It also changes thelogp
test to to compare thelogp
to the reference value for points drawn at random in the zero sum manifold and not only at the mode.Checklist
Bugfixes
logp
expression for theZeroSumNormal
distribution📚 Documentation preview 📚: https://pymc--6872.org.readthedocs.build/en/6872/