Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move slightly duplicated RVs to PyTensor #6502

Closed
wants to merge 3 commits into from

Conversation

soma2000-lang
Copy link
Contributor

@soma2000-lang soma2000-lang commented Feb 5, 2023

What is this PR about?

WaldRV (extra param)
StudentTRV (duplicated)
Partially address #6479
@ricardoV94 @OriolAbril @michaelosthege @larryshamalama @aloctavodia

@soma2000-lang soma2000-lang changed the title adding Move slightly duplicated RVs to PyTensor Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #6502 (98a6c69) into main (ac9652e) will decrease coverage by 16.51%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6502       +/-   ##
===========================================
- Coverage   94.82%   78.32%   -16.51%     
===========================================
  Files         148      148               
  Lines       27818    27802       -16     
===========================================
- Hits        26379    21776     -4603     
- Misses       1439     6026     +4587     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 65.09% <ø> (-32.59%) ⬇️
pymc/tests/logprob/test_utils.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_cumsum.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_mixture.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_abstract.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_rewriting.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_joint_logprob.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_composite_logprob.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/distributions/test_continuous.py 0.00% <0.00%> (-99.78%) ⬇️
pymc/tests/logprob/test_transforms.py 0.00% <0.00%> (-99.76%) ⬇️
... and 51 more

@soma2000-lang
Copy link
Contributor Author

just a gentle reminder @ricardoV94 @OriolAbril @michaelosthege @larryshamalama @aloctavodia

@michaelosthege
Copy link
Member

Looks like the tests fail because WaldRV from PyTensor has a fewer parameters?

TypeError: WaldRV.__call__() got multiple values for argument 'size'

@soma2000-lang
Copy link
Contributor Author

@michaelosthege surely looking into this

@ricardoV94
Copy link
Member

Closing this one for lack of activity. Feel free to open a new one if you want to still pursue it!

@ricardoV94 ricardoV94 closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants