Move slightly duplicated RVs to PyTensor #6499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soma2000-lang
changed the title
soma2000-lang
changed the title
|
These RVs will need to be imported from pytensor. |
|
Yes @michaelosthege I have checked Pytensor , they have been implementated there. |
Then in the files you changes, you should import these classes from PyTensor. Also make sure to run pre-commit before pushing, and you can check here for how to to parts of the test suite locally: https://docs.pymc.io/en/latest/contributing/running_the_test_suite.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fixes #6479
@ricardoV94 @OriolAbril @michaelosthege