Remove custom math functions #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
remove_custom_math_functions
branch
2 times, most recently
from
035e104
to
ca569a4
Compare
Codecov Report
@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
+ Coverage 72.11% 72.16% +0.04%
==========================================
Files 85 85
Lines 13739 13736 -3
==========================================
+ Hits 9908 9912 +4
+ Misses 3831 3824 -7
|
twiecki
reviewed
Jul 13, 2021
twiecki
reviewed
Jul 13, 2021
twiecki
reviewed
Jul 13, 2021
ricardoV94
force-pushed
the
remove_custom_math_functions
branch
from
ca569a4
to
f516009
Compare
twiecki
approved these changes
Jul 13, 2021
…deprecate `log1mexp` in favor of Aesara implementations. Closes pymc-devs#4747
ricardoV94
force-pushed
the
remove_custom_math_functions
branch
from
f516009
to
b14d303
Compare
twiecki
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom
logaddexp,logsumexp, andlog1pexpfunctions and deprecateslog1mexpin favor of Aesara implementations.A deprecation warning is added for
log1mexp(and the numpy counterpart) because the Aesara function, more logically, expects a negative input.Also fixed a bug in
log1mexp_numpywhen the input was an integer.Closes #4747