Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pymc-devs/pymc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f3df36b
Choose a base ref
...
head repository: pymc-devs/pymc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 864ecb3
Choose a head ref
  • 13 commits
  • 51 files changed
  • 5 contributors

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    4d2b2ef View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. uncommented bambi lines

    Geoff Nordling authored and twiecki committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    eb88380 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Remove unused test util

    ricardoV94 authored and twiecki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    0fa051d View commit details
    Browse the repository at this point in the history
  2. New logprob inference logic

    This commit changes the logic used for logprob inference. Instead of eager bottom-up conversion to measurable variables in the IR rewrites, we only convert nodes whose outputs were marked as "needs_measuring". This is achieved with the new `PreserveRVMappings.request_measurable` method.
    
    This strategy obviates the need to undo unnecessary conversions. It also obviates a subtle need for graph cloning via the `ignore_logprob` helper, which prevented intermediate measurable rewrites from being reversed when they were needed to derive the logprob of valued variables, but were not directly valued. This indirect role of `ignore_logprob` is now done more explicitly and efficiently via the `request_measurable` method.
    
    All other uses of `ignore_logprob` (and `reconsider_logprob`) were removed from the codebase
    
    The `get_measurable_outputs` dispatching was also abandoned in favor of only considering outputs associated with value variables.
    
    A new MergeOptimizerRewrite was written to further target local rewrites to only those nodes whose variables have been marked as `needs_measuring`.
    ricardoV94 authored and twiecki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    13f9894 View commit details
    Browse the repository at this point in the history
  3. Cleanup RV in graph checks

    ricardoV94 authored and twiecki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    7ed5b71 View commit details
    Browse the repository at this point in the history
  4. Fix logprob of check_and_raise

    ricardoV94 authored and twiecki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9bba026 View commit details
    Browse the repository at this point in the history
  5. Allow composition of interdependent container variables

    Join/MakeVector/IfElse can output multiple interdependent variables. These are potentially measurable because in the logp each output is given a distinct value variable. However, this isn't known during the IR rewrites.
    
    To circumvent this issue, we run an inner IR rewrite after giving dummy value variables to each output
    ricardoV94 authored and twiecki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a30e0d4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5b68edc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    261862d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. More informative error message for unused step sampler arguments (#6738)

    Co-authored-by: Joseph Hall <joseph.hall@bp.com>
    jahall and Joseph Hall authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a32c5e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    2ac88af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b5f437 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Fix bug in switch mixture logp

    The True and False branches were being mixed up
    ricardoV94 committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    864ecb3 View commit details
    Browse the repository at this point in the history
Loading