-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: pymc-devs/pymc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f3df36b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: pymc-devs/pymc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 864ecb3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 51 files changed
- 5 contributors
Commits on Jun 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4d2b2ef - Browse repository at this point
Copy the full SHA 4d2b2efView commit details
Commits on Jun 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eb88380 - Browse repository at this point
Copy the full SHA eb88380View commit details
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0fa051d - Browse repository at this point
Copy the full SHA 0fa051dView commit details -
This commit changes the logic used for logprob inference. Instead of eager bottom-up conversion to measurable variables in the IR rewrites, we only convert nodes whose outputs were marked as "needs_measuring". This is achieved with the new `PreserveRVMappings.request_measurable` method. This strategy obviates the need to undo unnecessary conversions. It also obviates a subtle need for graph cloning via the `ignore_logprob` helper, which prevented intermediate measurable rewrites from being reversed when they were needed to derive the logprob of valued variables, but were not directly valued. This indirect role of `ignore_logprob` is now done more explicitly and efficiently via the `request_measurable` method. All other uses of `ignore_logprob` (and `reconsider_logprob`) were removed from the codebase The `get_measurable_outputs` dispatching was also abandoned in favor of only considering outputs associated with value variables. A new MergeOptimizerRewrite was written to further target local rewrites to only those nodes whose variables have been marked as `needs_measuring`.
Configuration menu - View commit details
-
Copy full SHA for 13f9894 - Browse repository at this point
Copy the full SHA 13f9894View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed5b71 - Browse repository at this point
Copy the full SHA 7ed5b71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bba026 - Browse repository at this point
Copy the full SHA 9bba026View commit details -
Allow composition of interdependent container variables
Join/MakeVector/IfElse can output multiple interdependent variables. These are potentially measurable because in the logp each output is given a distinct value variable. However, this isn't known during the IR rewrites. To circumvent this issue, we run an inner IR rewrite after giving dummy value variables to each output
Configuration menu - View commit details
-
Copy full SHA for a30e0d4 - Browse repository at this point
Copy the full SHA a30e0d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b68edc - Browse repository at this point
Copy the full SHA 5b68edcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 261862d - Browse repository at this point
Copy the full SHA 261862dView commit details
Commits on Jun 7, 2023
-
More informative error message for unused step sampler arguments (#6738)
Co-authored-by: Joseph Hall <joseph.hall@bp.com>
Configuration menu - View commit details
-
Copy full SHA for a32c5e7 - Browse repository at this point
Copy the full SHA a32c5e7View commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2ac88af - Browse repository at this point
Copy the full SHA 2ac88afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b5f437 - Browse repository at this point
Copy the full SHA 8b5f437View commit details
Commits on Jun 9, 2023
-
Fix bug in switch mixture logp
The True and False branches were being mixed up
Configuration menu - View commit details
-
Copy full SHA for 864ecb3 - Browse repository at this point
Copy the full SHA 864ecb3View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff f3df36b...864ecb3