Repository navigation
fix(mobile): fence rollback status to the current session - #849
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Sep 24, 2026
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…status-freshness-20260924
…status-freshness-20260924 # Conflicts: # packages/client-runtime/src/connection/model.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On reconnect, mobile could display a cached completed rollback while a newer shell projection reported pending or manual recovery. Delayed native confirmations could also dispatch after the active RPC session changed. The UI now compares event sequence and session identity across detail and shell, keeps uncertain status visible while disabling mutating actions, and rechecks the current session before a queued command executes.
Manual recovery previously could not become actionable because the detail and shell contracts carried no shared rollback operation identity. The server now projects its server-generated saga UUID through the event, detail, shell, and persisted projection. Recovery requires that exact UUID and rechecks the durable phase after claim; older recovery callers that omit the ID fail closed. New mobile revert requests also carry the rollback operation they displayed (including an explicit
nullwhen none existed), so server admission rejects a delayed request if that operation has changed. Both revert and recovery bind their expected owner to the exact RPC session selected at dispatch, preventing a reconnect between the UI check and request binding from sending to a replacement connection. The UUID is distinct from private provider anchors, native sessions, paths, and receipts. Migration 066 adds a nullable projection column for existing databases.Focused tests cover recovery identity and post-claim races, stale revert admission, projected status and migration, mobile reconciliation, and session-bound command execution, including a forced reconnect between the first guard and RPC binding. After reconciliation with current
pylon, focused tests passed across the affected server, contracts, client-runtime, and mobile suites; contracts, client-runtime, server, and mobile typechecks passed. Scoped lint, formatting, and diff checks passed. Independent final-head adversarial review found and verified the fix for the mid-dispatch session race, with no remaining findings.Isolated iPhone Simulator presentation check with synthetic projection data: before reconnect and manual recovery after reconnect. The thread history remained visible and Send was disabled. This fixture checks rendering and fail-closed presentation, not a real rollback saga. Full server admission, privacy, native-generation, and checkpoint-ref acceptance work tracked under #200 remains separate. Android device rendering was unavailable because this host has no Android SDK.
Implemented by GPT-6 Sol (low) through the Pylon Codex harness; supervised and device-checked by GPT-6 Codex.