Repository navigation
fix(server): keep rejected Claude prompts out of running turns - #740
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unreadable Claude image attachment could fail
sendTurnafter the adapter had already emittedturn.startedand marked the session running. No prompt reached the SDK, so the thread appeared to wait indefinitely and a later message was steered into that empty turn.Prepare the prompt before changing turn or recovery state, and recheck session ownership after asynchronous preparation and provider setup. This keeps rejected sends out of the runtime queue and rejects sends that finish after a session stop. Regression tests cover missing attachments and stop during provider setup.
Validation:
vp test run apps/server/src/provider/Layers/ClaudeAdapter.test.ts(176 passed);vp lint apps/server/src/provider/Layers/ClaudeAdapter.ts apps/server/src/provider/Layers/ClaudeAdapter.test.ts;vp run -F t3 typecheck.Built with GPT-6 Sol low in the Codex harness.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.