Repository navigation
refactor(web): self-contain composer context strip visibility in BranchToolbar (#436) - #721
Merged
rynfar merged 1 commit intoSep 21, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
rynfar
deleted the
refactor/issue-436-composer-context-strip-visibility
branch
September 21, 2026 22:52
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436
Summary
Previously,
ChatViewmirrored the internal visibility rules of every child insideBranchToolbar(showGitControls,showEnvironmentIndicator,hostsRestingComposerControls,restingComposerControlsVisible,hasCapacityReading) to decide whether to mount and display the composer context strip. This duplication broke whenever children changed their rendering rules or during rollbacks.This PR refactors
BranchToolbarto self-contain its content measurement and visibility:BranchToolbarmeasures its laid-out DOM children viaresolveContextStripHasContentand reports changes upward viaonContextStripVisibilityChange.resolveInitialContextStripVisibilityto avoid layout shift on initial render.ChatViewby removing duplicate child flags andresolveComposerContextStripVisibility.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.