Repository navigation
fix(mobile): prevent duplicate Stop control during dictation error phase (#244) - #716
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244
Problem
In
apps/mobile/src/features/threads/ThreadComposer.tsx, the collapsed composer actions rendered under{!isExpanded && !voiceInput.isBusy}and the toolbar rendered under{isToolbarVisible}(whereisToolbarVisible = isExpanded || isVoiceInputPresented).During the dictation error phase,
isVoiceInputPresentedis true (displaying the error status label) whilevoiceInput.isBusyis false (as error is not a busy phase). When the composer was not expanded, both conditions evaluated to true, causing two Stop buttons and duplicate dictation actions to render simultaneously.Solution
threadComposerShowsCollapsedActions({ isToolbarVisible })(i.e.!isToolbarVisible) so that collapsed actions and the toolbar actions are strictly mutually exclusive by construction.ThreadComposer.test.tsverifying that collapsed actions are hidden whenever the toolbar is visible (such as during dictation error status presentation).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.