Skip to content

fix(test): use pinned DEVICE_HUB_VERSION in LocalDeviceHost test fixture #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rynfar merged 2 commits into from
Sep 21, 2026
Merged

fix(test): use pinned DEVICE_HUB_VERSION in LocalDeviceHost test fixture #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379ece0
fix(test): use pinned DEVICE_HUB_VERSION in LocalDeviceHost test fixture
rynfar Sep 21, 2026
47ef72c
fix(knip): ignore unused device tool exports in packages/client-runtime
rynfar Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/server/src/device/LocalDeviceHost.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import * as Path from "effect/Path";
import * as FileSystem from "effect/FileSystem";

import * as LocalDeviceHost from "./LocalDeviceHost.ts";
import { DEVICE_HUB_VERSION } from "./DeviceToolchain.ts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as ChildProcessSpawner from "effect/unstable/process/ChildProcessSpawner";
import { HttpClient } from "effect/unstable/http";
Expand Down Expand Up @@ -123,7 +124,7 @@ it.effect("closes an owned hub process when readiness is interrupted before publ
const fs = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
const baseDir = yield* fs.makeTempDirectoryScoped({ prefix: "pylon-device-start-" });
const installDir = path.join(baseDir, "tools", "expo-device-hub", "0.9.0");
const installDir = path.join(baseDir, "tools", "expo-device-hub", DEVICE_HUB_VERSION);
const entryPath = path.join(
installDir,
"node_modules",
Expand All @@ -134,7 +135,7 @@ it.effect("closes an owned hub process when readiness is interrupted before publ
);
yield* fs.makeDirectory(path.dirname(entryPath), { recursive: true });
yield* fs.writeFileString(entryPath, "");
yield* fs.writeFileString(path.join(installDir, ".install-complete"), "0.9.0");
yield* fs.writeFileString(path.join(installDir, ".install-complete"), DEVICE_HUB_VERSION);
const readinessEntered = yield* Deferred.make<void>();
const finalized = yield* Ref.make(0);
const host = yield* LocalDeviceHost.make().pipe(
Expand Down
4 changes: 4 additions & 0 deletions knip.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@
// These workspace packages are private to this monorepo.
"includeEntryExports": true,
},
"packages/client-runtime": {
"includeEntryExports": true,
"ignoreIssues": { "src/state/device.ts": ["exports"] },
},
"packages/effect-acp": {
"includeEntryExports": true,
"entry": ["test/fixtures/*.ts"],
Expand Down
Loading