Repository navigation
feat(device,preview): integrate batch 4 simulator stream reliability and preview feedback (#698) - #699
Merged
Conversation
…and preview feedback (#698) Adopts 5 targeted upstream commits from cycle 6d1d549441..2efb8178d8: - 58f89818e3 (#12807): fix(server): tolerate shutting down an iOS simulator that is already off - 051a4057a6 (#12808): fix(web): device Reconnect starts one stream instead of two - 1ba471a37c (#12809): chore(server): bump device tooling versions - 9f73ca3677 (#12639): fix(devices): recover simulator streams after failures - 55c24273a0 (#12779): fix(desktop): align preview recording cursors and show input feedback Adversarial review findings resolved: - Preserved Pylon bounded videoBitsPerSecond calculations in createMediaRecorder - Verified iOS simulator idempotent shutdown via fetchDevices(ready) - Retained Pylon Effect service runtime and isolation boundaries
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #698
Summary of Upstream Integrations & Adversarial Review
Adopts 5 targeted upstream commits from cycle
6d1d549441..2efb8178d8into Pylon with strict adherence to Pylon invariants, Effect services, and architecture:58f89818e3(#12807) (apps/server/src/device/DeviceService.ts,DeviceService.test.ts):serve-simduring shutdown, re-probes device state withfetchDevices(ready), and considers it an idempotent success ifbooted === false. Added comprehensive test suite.051a4057a6(#12808) (apps/web/src/components/device/DeviceStreamView.tsx,DeviceStreamView.test.tsx):Reconnectbutton starting two streams simultaneously by not callingrefreshDeviceHubAccessif access is unchanged.1ba471a37c(#12809) (apps/server/src/device/DeviceToolchain.ts,third-party-licenses.config.json,DeviceToolchain.test.ts):DEVICE_HUB_VERSIONto0.10.1andAGENT_DEVICE_VERSIONto0.21.7.9f73ca3677(#12639) (apps/web/src/components/device/deviceStream.ts,deviceStream.test.ts,DeviceLoadingView.tsx):55c24273a0(#12779) (apps/desktop/src/preview/,apps/web/src/browser/,packages/contracts/):Adversarial Review Findings & Adaptations
videoBitsPerSecondcalculations increateMediaRecorder.PreviewViewactive recording tab isolation and replacement server epoch handling.Verification
vp check: 0 errors across 3,951 files.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.