Repository navigation
feat(pair): refuse a rewind while the executor is working - #658
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rynfar
force-pushed
the
feat/pair-rewind-guard
branch
from
September 18, 2026 22:21
7363387 to
c8f534a
Compare
|
Deployment failed for project pylon-marketing with the following error: Learn More: https://vercel.com/pylon-code?upgradeToPro=build-rate-limit |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
rynfar
force-pushed
the
feat/pair-rewind-guard
branch
from
September 18, 2026 22:33
c8f534a to
29445f3
Compare
Collaborator
Author
|
Merging with the Vercel preview check red: it failed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Web and mobile refuse to rewind a lead while its pair executor holds a turn, and say why: "Stop the executor before rewinding. It works in this thread's worktree and would write over the restored files."
Why
A lead and its executor share one worktree. The server already interrupts a running executor when a rewind is requested, but it says so itself: the executor can still write for a moment before the interrupt lands, onto files the rewind is restoring. Changing rewind admission in the decider was ruled out to keep pair mode out of the core, so the clients ask first and the reactor stays as the backstop.
How
pairRewindBlockedReasoninclient-runtime/state/pair.ts(pure): blocked while the executor is starting, running, or paused on an approval or a question, since it resumes and writes once answered. Not blocked when the pair is off, the executor is idle or finished, or the thread is another lead's or another environment's.ChatView's rewind handler checks it right after the existing "interrupt the current turn first" check and reports it the same way. That is the only change toChatView.ThreadRouteScreenshows it as a "Rollback unavailable" alert before the confirmation.Verification
vp test run packages/client-runtime/src/state: all passing, with two new tests written first (one seen failing; the "allows it" cases pass against the stub by construction).@t3tools/client-runtime,@t3tools/web,@t3tools/mobile: 0 errors. Format clean; no new lint warnings in the two touched screens.Part of #622.
Model: Claude Fable 5.1, in Pylon via the Claude Code harness.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.