Repository navigation
fix(connections): block incompatible servers and preserve saved environments - #595
Merged
Merged
Conversation
…1478) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 2587c8060c103245b4f970b925977008f2592d1d)
(cherry picked from commit 2c16c1d264173d86fc354e9a4c0c78cd42e514b7)
…990) (cherry picked from commit 935c55b3778fdeae0e25b250ce2a9fa7e79c0327)
…r machine icon (#12026) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit c1b2ed6504bbd57440d03c6a5af2736f33be7c65)
… (#12030) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 6ee03240bccd9287a8c2246e9547697aa5857998)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Collaborator
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Incompatible remote servers currently enter connection/retry flows without an explicit protocol check, and disconnecting saved environments can require removing them. This adds saved off-state, protocol preflight and disabled discovery entries, with neutral explanations and stable machine icons. Credentials, configuration and cached history remain saved while off.
Pylon keeps its connection layouts, editing controls, WSL lifecycle ownership and authentication parameters. Compatibility belongs to the saved target/profile; unrelated GitHub account-routing code is not imported. An explicit Check again action on web and reconnect on mobile clears an obsolete block and reruns preflight after a server upgrade. A still-incompatible server is blocked again before any RPC socket opens. Older descriptors without a version retain protocol 1 semantics; this does not guarantee compatibility between independently changed forks.
Sources through frozen head
6d1d549441be84f19696ab59ed7e2fbf305280d4:2587c8060c103245b4f970b925977008f2592d1d(#11478), required saved off-state dependency; Theo Browne, co-author Claude Fable 5.1.2c16c1d264173d86fc354e9a4c0c78cd42e514b7(#11974), protocol preflight; Julius Marminge.935c55b3778fdeae0e25b250ce2a9fa7e79c0327(#11990), discovery gating; Julius Marminge.c1b2ed6504bbd57440d03c6a5af2736f33be7c65(#12026), neutral unsupported presentation; Julius Marminge, co-author Claude Fable 5.1.6ee03240bccd9287a8c2246e9547697aa5857998(#12030), stable discovered icons; Julius Marminge, co-author Claude Fable 5.1.Original authored commits and source references are retained. Closes Upstream integration cycle: environment compatibility #594. Review cursor unchanged; no release/install.
Validation: 208 focused tests across compatibility/resolution, registry/retry, onboarding, persistence, contracts/server descriptor, web discovery, shared state and mobile projections. Scoped contracts/client-runtime/web/mobile/desktop/server typechecks and changed-file lint pass. Recovery regressions verify both an upgraded direct environment reconnecting and a still-incompatible environment remaining blocked without opening an RPC session.
Browser verification passed in isolated worktrees with a synthetic incompatible direct server: metadata is rechecked and zero RPC sockets open while unsupported. Before/after images and retry video. Native mobile rendered/live-relay verification is not claimed.
CI exposed a native dependency leaking into the existing mobile row unit test through ThemedSwitch; the fixture now mocks that component like its other native UI dependencies. All eight affected tests pass locally. All final-head CI checks pass at
f0b455f19264eebfa83ce3f8162b0fb1d2cf63f5.Implemented and verified with GPT-6 through the Codex harness.