Skip to content

fix(editors): open remote projects safely in Zed - #499

Merged
rynfar merged 3 commits into
pylonfrom
upstream/2026-09-12-desktop
Sep 12, 2026
Merged

rynfar merged 3 commits into
pylonfrom
upstream/2026-09-12-desktop

Conversation

@rynfar

@rynfar rynfar commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

Remote projects can now open in Zed over SSH, including root paths and Windows system-drive paths. Desktop permits only Zed SSH URLs; decoded host validation rejects encoded credentials, separators, controls, and malformed escapes while retaining Pylon’s external URL restrictions.

Cycle #497, frozen range 6c583620ff7ad3235b135af7107c0543467eecfa..4a4c6dd2adc350a68ba18bb28b24b5a7e4660dab.

Sources adopted:

  • 0f602b3372b300ae94084bd3fe7dbaadaa58ba3a
  • 20ef25037f455a570426ac2a93fcf499d1f91167

Validation: 25 focused ElectronShell/remoteOpen tests; 12 ElectronShell cases rerun after adversarial fix; desktop, web, and contracts typechecks; changed-file lint and formatting. Independent review identified the encoded-authority bypass and the regression cases now cover it. No layout change or release/install.

Implemented with GPT-6 in Codex.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

maria-rcks and others added 3 commits September 12, 2026 00:13
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 0f602b3372b300ae94084bd3fe7dbaadaa58ba3a)
…ks (#11044)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 20ef25037f455a570426ac2a93fcf499d1f91167)
@vercel

vercel Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pylon-marketing Ready Ready Preview Sep 12, 2026 6:18am UTC

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Sep 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 14.1 KiB 14.0 KiB −39 B (−0.3%) 15.1 KiB ✅
Codex Thread snapshot wire 7.2 KiB 7.2 KiB −10 B (−0.1%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.9 KiB 6.8 KiB −29 B (−0.4%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 58.8 KiB 58.8 KiB −44 B (−0.1%) 66.4 KiB ✅
Codex Live turn messages 10 9 −1 (−10.0%) 21 ✅
Claude Total thread wire 14.1 KiB 14.1 KiB +19 B (+0.1%) 15.1 KiB ✅
Claude Thread snapshot wire 7.2 KiB 7.2 KiB +4 B (+0.1%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.9 KiB 6.9 KiB +15 B (+0.2%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 59.7 KiB 59.7 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 10 10 0 (0.0%) 21 ✅

Baseline: f3402be · PR result: e10e5d9 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.6 KiB
  • Claude decoded thread snapshot: 116.3 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

rynfar commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

Adversarial review complete against e10e5d9f21864c5ca00c4cac5f0b69cafe1e1de8. The decoded Zed host segment now rejects encoded credentials/separators, controls and malformed escapes, with focused regressions. Reviewed the full combined editor URL builder, Electron allowlist and root/Windows path tests; no remaining actionable finding. Final-head CI is green; landing under the maintainer's standing integration approval.

@rynfar
rynfar merged commit 25a0a21 into pylon Sep 12, 2026
19 checks passed
@rynfar
rynfar deleted the upstream/2026-09-12-desktop branch September 12, 2026 06:27

This branch was successfully deployed

1 active deployment
Preview — e10e5d9f Deployed Sep 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants