Repository navigation
fix(ci): unbreak mobile preview CD against eas-cli 22 - #41
Merged
Merged
Conversation
continuous-deploy-fingerprint failed with "Cannot read properties of undefined (reading 'ownerAccount')" after its builds had already succeeded. eas-cli 22 renamed the build JSON fields (project -> app, channel -> updateChannel, runtimeVersion -> runtime) and the action still reads build.project.ownerAccount when posting its PR comment, so the workflow installed the breakage by asking for `latest`. Pins eas-cli to 21.8.0 for this workflow only; the production workflow calls eas directly and stays current. Also pins the action itself to v9: it was the one action reference in the repository tracking an unreleased branch, so CI could change without a commit here. Documents the mobile build path in the app README. EAS build servers read the EAS-hosted environment, never this checkout, so a gitignored .env.local reaches nothing. Missing PYLON_EAS_PROJECT_ID silently ships a binary with over-the-air updates disabled, which cost a full rebuild cycle to discover; missing Clerk values silently omit every Connect surface. Both are now named alongside a command to verify a finished artifact rather than assume. Upstream issue: expo/expo-github-action#358
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile preview CD failed with
Cannot read properties of undefined (reading 'ownerAccount')— after its EAS builds had already succeeded, so the job went red on a step that only posts a PR comment.Cause
eas-cli 22 renamed the build JSON fields (
project→app,channel→updateChannel,runtimeVersion→runtime).continuous-deploy-fingerprintstill does:build.projectis now undefined. Tracked upstream as expo/expo-github-action#358, still open. The workflow asked foreas-version: latest, so it installed the breakage on its own.Fix
Pins
eas-version: 21.8.0— the last release before the rename — for this workflow only. The production workflow callseasdirectly, never runs this action, and stays onlatest. The pin carries the issue link and the condition to lift it.Also pins the action to
@v9. It was the only action reference in the repository tracking an unreleased branch, so CI behaviour could change with no commit here. Worth notingcontinuous-deploy-fingerprintdoes not exist inv8, which is why the setup action beside it is a different major.Documentation
apps/mobile/README.mdgains the mobile build path, because two failure modes in this area are silent and both cost real time this week:eas buildarchives with git, so a gitignored.env/.env.localreaches nothing.PYLON_EAS_PROJECT_IDships a binary withupdates.enabled: false. It installs and runs normally but can never receive an OTA — discovered only after a full rebuild cycle.Adds a command to verify a finished artifact instead of assuming, plus device-install and OTA runtime-version notes (an update published under
fingerprintnever lands on anappVersionbuild).Verification
eas-versionand both action refs confirmed in the parsed YAMLcontinuous-deploy-fingerprintconfirmed absent atv8, present atv9andmaineas-cli@21.8.0confirmed as the last 21.x releaseStacks cleanly with #37, which touches different hunks of the same workflow.
Model: Claude Opus 5. Harness: Claude Code.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.