-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max-positional-arguments comments in example config files #9914
Fix max-positional-arguments comments in example config files #9914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch ! This is generated using this:
Lines 40 to 46 in 0261637
[[before_commit]] | |
name = "Upgrade the pylintrc examples" | |
cmd = "pylint --rcfile=/dev/null --generate-rcfile > examples/pylintrc" | |
[[before_commit]] | |
name = "Upgrade the toml examples" | |
cmd = "pylint --rcfile=/dev/null --generate-toml-config > examples/pyproject.toml" |
Something need to change in the code directly, and the toml would be modified too. (No need to use tbump, you can launch the command directly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I noticed this too and was going to let this get fixed by the release tooling but glad to have the PR ππ»
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I see from Pierre's comment that this wasn't generated using the command.
We will also want the toml file updated. |
9bca663
to
db92a33
Compare
Thanks for the reviews + tips. I updated both config files the proper way now :). |
Thanks! |
I was wondering why nothing changed in the code. Then I realized that it was a missing generation following another earlier fix. Would have been fixed for 3.3.0 release but we could add it to pre-commit or the doc pipeline to avoid this. |
Type of Changes
Description
The comment for
min-public-methods
got accidentally reused.