Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max-positional-arguments comments in example config files #9914

Merged

Conversation

correctmost
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

The comment for min-public-methods got accidentally reused.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ! This is generated using this:

pylint/tbump.toml

Lines 40 to 46 in 0261637

[[before_commit]]
name = "Upgrade the pylintrc examples"
cmd = "pylint --rcfile=/dev/null --generate-rcfile > examples/pylintrc"
[[before_commit]]
name = "Upgrade the toml examples"
cmd = "pylint --rcfile=/dev/null --generate-toml-config > examples/pyproject.toml"

Something need to change in the code directly, and the toml would be modified too. (No need to use tbump, you can launch the command directly)

@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry labels Sep 5, 2024
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I noticed this too and was going to let this get fixed by the release tooling but glad to have the PR πŸ‘πŸ»

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I see from Pierre's comment that this wasn't generated using the command.

@jacobtylerwalls
Copy link
Member

We will also want the toml file updated.

@correctmost correctmost changed the title Fix max-positional-arguments comment in examples/pylintrc Fix max-positional-arguments comments in example config files Sep 5, 2024
@correctmost
Copy link
Contributor Author

Thanks for the reviews + tips. I updated both config files the proper way now :).

@jacobtylerwalls jacobtylerwalls merged commit d561731 into pylint-dev:main Sep 5, 2024
23 of 24 checks passed
@jacobtylerwalls
Copy link
Member

Thanks!

@Pierre-Sassoulas
Copy link
Member

I was wondering why nothing changed in the code. Then I realized that it was a missing generation following another earlier fix. Would have been fixed for 3.3.0 release but we could add it to pre-commit or the doc pipeline to avoid this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants