pylint-dev · jacobtylerwalls · Jul 3, 2023 · Jun 23, 2023 · Jul 1, 2023 · Jul 1, 2023
diff --git a/doc/whatsnew/2/2.15/index.rst b/doc/whatsnew/2/2.15/index.rst
@@ -383,9 +383,6 @@ Release date: 2022-09-07
 - Fix false positive for ``too-many-function-args`` when a function call is assigned to a class attribute inside the class where the function is defined.
 
   Closes #6592 (`#6592 <https://github.com/pylint-dev/pylint/issues/6592>`_)
-- Fix ``used-before-assignment`` for functions/classes defined in type checking guard.
-
-  Closes #7368 (`#7368 <https://github.com/pylint-dev/pylint/issues/7368>`_)
 - Fix ignored files being linted when passed on stdin.
 
   Closes #4354 (`#4354 <https://github.com/pylint-dev/pylint/issues/4354>`_)

diff --git a/doc/whatsnew/2/2.17/index.rst b/doc/whatsnew/2/2.17/index.rst
@@ -112,7 +112,7 @@ False Positives Fixed
 Other Bug Fixes
 ---------------
 
-- Improve output of ``consider-using-generator`` message for ``min()` calls
+- Improve output of ``consider-using-generator`` message for ``min()`` calls
   with ``default`` keyword.
 
   Closes #8563 (`#8563 <https://github.com/PyCQA/pylint/issues/8563>`_)

diff --git a/doc/whatsnew/fragments/8563.bugfix b/doc/whatsnew/fragments/8563.bugfix
@@ -1,3 +1,3 @@
-Improve output of ``consider-using-generator`` message for ``min()` calls with ``default`` keyword.
+Improve output of ``consider-using-generator`` message for ``min()`` calls with ``default`` keyword.
 
 Closes #8563
diff --git a/pylint/checkers/refactoring/refactoring_checker.py b/pylint/checkers/refactoring/refactoring_checker.py
@@ -1133,16 +1133,12 @@ def _check_super_with_arguments(self, node: nodes.Call) -> None:
         if not isinstance(node.func, nodes.Name) or node.func.name != "super":
             return
 
-        # pylint: disable=too-many-boolean-expressions
         if (
             len(node.args) != 2
-            or not isinstance(node.args[1], nodes.Name)
+            or not all(isinstance(arg, nodes.Name) for arg in node.args)
             or node.args[1].name != "self"
-            or not isinstance(node.args[0], nodes.Name)
-            or not isinstance(node.args[1], nodes.Name)
-            or node_frame_class(node) is None
-            # TODO: PY38: Use walrus operator, this will also fix the mypy issue
-            or node.args[0].name != node_frame_class(node).name  # type: ignore[union-attr]
+            or (frame_class := node_frame_class(node)) is None
+            or node.args[0].name != frame_class.name
         ):
             return
 

diff --git a/tests/functional/a/alternative/alternative_union_syntax_error.rc b/tests/functional/a/alternative/alternative_union_syntax_error.rc
@@ -2,5 +2,4 @@
 py-version=3.8
 
 [testoptions]
-min_pyver=3.8
 max_pyver=3.10
diff --git a/tests/functional/a/alternative/alternative_union_syntax_py37.rc b/tests/functional/a/alternative/alternative_union_syntax_py37.rc
@@ -1,5 +1,2 @@
 [main]
 py-version=3.8
-
-[testoptions]
-min_pyver=3.8
diff --git a/tests/functional/a/assignment/assignment_expression.rc b/tests/functional/a/assignment/assignment_expression.rc
diff --git a/tests/functional/a/attribute_defined_outside_init_py38.rc b/tests/functional/a/attribute_defined_outside_init_py38.rc
@@ -1,5 +1,2 @@
 [main]
 load-plugins=pylint.extensions.typing
-
-[testoptions]
-min_pyver=3.8
diff --git a/tests/functional/b/bad_reversed_sequence_py38.rc b/tests/functional/b/bad_reversed_sequence_py38.rc
diff --git a/tests/functional/c/cached_property.rc b/tests/functional/c/cached_property.rc
diff --git a/tests/functional/d/deprecated/deprecated_methods_py38.rc b/tests/functional/d/deprecated/deprecated_methods_py38.rc
@@ -1,3 +1,2 @@
 [testoptions]
-min_pyver=3.8
 max_pyver=3.9
diff --git a/...nsider_refactoring_into_while_condition/consider_refactoring_into_while_condition_py38.rc b/...nsider_refactoring_into_while_condition/consider_refactoring_into_while_condition_py38.rc
@@ -1,4 +1,2 @@
 [MAIN]
 load-plugins=pylint.extensions.consider_refactoring_into_while_condition,
-[testoptions]
-min_pyver=3.8
diff --git a/tests/functional/ext/docparams/docparams_py38.rc b/tests/functional/ext/docparams/docparams_py38.rc
@@ -6,6 +6,3 @@ accept-no-param-doc = no
 accept-no-raise-doc = no
 accept-no-return-doc = no
 accept-no-yields-doc = no
-
-[testoptions]
-min_pyver=3.8
diff --git a/tests/functional/ext/docparams/missing_param_doc_py38.rc b/tests/functional/ext/docparams/missing_param_doc_py38.rc
@@ -1,9 +1,6 @@
 [MASTER]
 load-plugins=pylint.extensions.docparams,
 
-[testoptions]
-min_pyver=3.8
-
 [PARAMETER_DOCUMENTATION]
 accept-no-param-doc=no
 accept-no-raise-doc=no

diff --git a/tests/functional/ext/no_self_use/no_self_use.rc b/tests/functional/ext/no_self_use/no_self_use.rc
@@ -1,5 +1,2 @@
 [main]
 load-plugins=pylint.extensions.no_self_use
-
-[testoptions]
-min_pyver=3.8
@@ -2,8 +2,5 @@
 py-version=3.8
 load-plugins=pylint.extensions.typing
 
-[testoptions]
-min_pyver=3.8
-
 [typing]
 runtime-typing=no
@@ -2,8 +2,5 @@
 py-version=3.8
 load-plugins=pylint.extensions.typing
 
-[testoptions]
-min_pyver=3.8
-
 [typing]
 runtime-typing=no
@@ -2,8 +2,5 @@
 py-version=3.8
 load-plugins=pylint.extensions.typing
 
-[testoptions]
-min_pyver=3.8
-
 [typing]
 runtime-typing=no
@@ -2,8 +2,5 @@
 py-version=3.8
 load-plugins=pylint.extensions.typing
 
-[testoptions]
-min_pyver=3.8
-
 [typing]
 runtime-typing=no
diff --git a/tests/functional/g/generic_alias/generic_alias_side_effects.rc b/tests/functional/g/generic_alias/generic_alias_side_effects.rc
diff --git a/tests/functional/k/keyword_arg_before_vararg_positional_only.rc b/tests/functional/k/keyword_arg_before_vararg_positional_only.rc
diff --git a/tests/functional/n/name/name_final.rc b/tests/functional/n/name/name_final.rc
diff --git a/tests/functional/n/name/name_final_snake_case.rc b/tests/functional/n/name/name_final_snake_case.rc
@@ -1,6 +1,3 @@
-[testoptions]
-min_pyver=3.8
-
 [BASIC]
 class-const-naming-style=snake_case
 const-naming-style=snake_case
diff --git a/tests/functional/n/named_expr_without_context_py38.rc b/tests/functional/n/named_expr_without_context_py38.rc
diff --git a/tests/functional/n/no/no_method_argument_py38.rc b/tests/functional/n/no/no_method_argument_py38.rc
diff --git a/tests/functional/n/non_ascii_name/non_ascii_name_assignment_expressions.rc b/tests/functional/n/non_ascii_name/non_ascii_name_assignment_expressions.rc
diff --git a/tests/functional/n/non_ascii_name/non_ascii_name_function_argument_py38.rc b/tests/functional/n/non_ascii_name/non_ascii_name_function_argument_py38.rc
@@ -1,3 +1,2 @@
 [testoptions]
-min_pyver=3.8
 max_pyver=3.9
diff --git a/tests/functional/n/non_ascii_name/non_ascii_name_kwargs_py38.rc b/tests/functional/n/non_ascii_name/non_ascii_name_kwargs_py38.rc
@@ -1,3 +1,2 @@
 [testoptions]
-min_pyver=3.8
 max_pyver=3.9
diff --git a/tests/functional/n/non_ascii_name/non_ascii_name_pos_and_kwonly_function.rc b/tests/functional/n/non_ascii_name/non_ascii_name_pos_and_kwonly_function.rc
diff --git a/tests/functional/n/none_dunder_protocols_py38.rc b/tests/functional/n/none_dunder_protocols_py38.rc
diff --git a/tests/functional/o/overridden_final_method_py38.rc b/tests/functional/o/overridden_final_method_py38.rc
diff --git a/tests/functional/p/positional_only_arguments_expected.rc b/tests/functional/p/positional_only_arguments_expected.rc
diff --git a/tests/functional/p/postponed/postponed_evaluation_pep585.rc b/tests/functional/p/postponed/postponed_evaluation_pep585.rc
@@ -1,3 +1,2 @@
 [testoptions]
-min_pyver=3.8
 max_pyver=3.9
diff --git a/tests/functional/p/postponed/postponed_evaluation_pep585_error.rc b/tests/functional/p/postponed/postponed_evaluation_pep585_error.rc
@@ -1,3 +1,2 @@
 [testoptions]
-min_pyver=3.8
 max_pyver=3.9
diff --git a/tests/functional/p/protocol_classes.rc b/tests/functional/p/protocol_classes.rc
diff --git a/tests/functional/p/protocol_classes_abstract.rc b/tests/functional/p/protocol_classes_abstract.rc
diff --git a/tests/functional/r/redundant_u_string_prefix.rc b/tests/functional/r/redundant_u_string_prefix.rc
diff --git a/tests/functional/r/regression/regression_posonly_args.rc b/tests/functional/r/regression/regression_posonly_args.rc
diff --git a/tests/functional/r/regression_02/regression_4660.rc b/tests/functional/r/regression_02/regression_4660.rc
diff --git a/tests/functional/s/singledispatch/singledispatch_method_py38.rc b/tests/functional/s/singledispatch/singledispatch_method_py38.rc
diff --git a/tests/functional/s/singledispatch/singledispatchmethod_function_py38.rc b/tests/functional/s/singledispatch/singledispatchmethod_function_py38.rc
diff --git a/tests/functional/s/subclassed_final_class_py38.rc b/tests/functional/s/subclassed_final_class_py38.rc
diff --git a/tests/functional/s/super/super_init_not_called_py38.rc b/tests/functional/s/super/super_init_not_called_py38.rc
diff --git a/tests/functional/s/superfluous_parens_walrus_py38.rc b/tests/functional/s/superfluous_parens_walrus_py38.rc
diff --git a/tests/functional/t/typedDict.rc b/tests/functional/t/typedDict.rc
diff --git a/tests/functional/u/undefined/undefined_loop_variable_py38.rc b/tests/functional/u/undefined/undefined_loop_variable_py38.rc
diff --git a/tests/functional/u/undefined/undefined_variable_py38.rc b/tests/functional/u/undefined/undefined_variable_py38.rc
diff --git a/tests/functional/u/undefined/undefined_variable_typing.rc b/tests/functional/u/undefined/undefined_variable_typing.rc
@@ -1,6 +1,2 @@
-[testoptions]
-# This was added as PyPy is only able to run this on 3.8 and above
-min_pyver=3.8
-
 [VARIABLES]
 additional-builtins=__additional_builtin__
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda_assignment.py b/tests/functional/u/unnecessary/unnecessary_lambda_assignment.py
@@ -32,3 +32,7 @@
 DICT = {1: lambda x: x, 2: lambda x: x + 1}
 for key, value in DICT.items():
     print(value(key))
+
+# Flag lambda expression assignments via named expressions as well.
+if (e := lambda: 2) and e():  # [unnecessary-lambda-assignment]
+    pass
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda_assignment.txt b/tests/functional/u/unnecessary/unnecessary_lambda_assignment.txt
@@ -12,3 +12,4 @@ unnecessary-lambda-assignment:22:4:22:15:<lambda>:"Lambda expression assigned to
 unnecessary-lambda-assignment:23:4:23:15:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
 unnecessary-lambda-assignment:26:10:26:21:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
 unnecessary-lambda-assignment:26:23:26:34:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
+unnecessary-lambda-assignment:37:9:37:18:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda_assignment_py38.py b/tests/functional/u/unnecessary/unnecessary_lambda_assignment_py38.py
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda_assignment_py38.rc b/tests/functional/u/unnecessary/unnecessary_lambda_assignment_py38.rc
diff --git a/tests/functional/u/unnecessary/unnecessary_lambda_assignment_py38.txt b/tests/functional/u/unnecessary/unnecessary_lambda_assignment_py38.txt
diff --git a/tests/functional/u/unnecessary/unnecessary_list_index_lookup.py b/tests/functional/u/unnecessary/unnecessary_list_index_lookup.py
@@ -152,3 +152,7 @@ def _get_extra_attrs(self, extra_columns):
 nums = list(range(20))
 for y, x in enumerate(nums, start=Y_START + 1):
     pass
+
+for idx, val in enumerate(my_list):
+    if (val := 42) and my_list[idx] == 'b':
+        print(1)
diff --git a/tests/functional/u/unnecessary/unnecessary_list_index_lookup_py38.py b/tests/functional/u/unnecessary/unnecessary_list_index_lookup_py38.py
diff --git a/tests/functional/u/unnecessary/unnecessary_list_index_lookup_py38.rc b/tests/functional/u/unnecessary/unnecessary_list_index_lookup_py38.rc
diff --git a/tests/functional/u/unspecified_encoding_py38.rc b/tests/functional/u/unspecified_encoding_py38.rc
diff --git a/tests/functional/u/unused/unused_import_positional_only_py38.rc b/tests/functional/u/unused/unused_import_positional_only_py38.rc
diff --git a/tests/functional/u/unused/unused_name_in_string_literal_type_annotation_py38.rc b/tests/functional/u/unused/unused_name_in_string_literal_type_annotation_py38.rc
diff --git a/tests/functional/u/unused/unused_typing_imports.rc b/tests/functional/u/unused/unused_typing_imports.rc
diff --git a/tests/functional/u/unused/unused_variable_py38.rc b/tests/functional/u/unused/unused_variable_py38.rc
@@ -1,5 +1,2 @@
-[testoptions]
-min_pyver=3.8
-
 [variables]
 allow-global-unused-variables=no
diff --git a/tests/functional/u/use/used_before_assignment_except_handler_for_try_with_return_py38.rc b/tests/functional/u/use/used_before_assignment_except_handler_for_try_with_return_py38.rc
diff --git a/tests/functional/u/used/used_before_assignment_ternary.rc b/tests/functional/u/used/used_before_assignment_ternary.rc
diff --git a/tests/functional/u/useless/useless_parent_delegation_py38.rc b/tests/functional/u/useless/useless_parent_delegation_py38.rc