Fix check unused arguments false positive bug #8542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emplis
force-pushed
the
fix-check-unused-args
branch
from
3411d52 to
64a5d0a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8542 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 174 174
Lines 18353 18361 +8
=======================================
+ Hits 17602 17610 +8
Misses 751 751
|
Emplis
force-pushed
the
fix-check-unused-args
branch
from
64a5d0a to
f9ef291
Compare
Pierre-Sassoulas
added
False Positive 🦟
Emplis
force-pushed
the
fix-check-unused-args
branch
from
f9ef291 to
3dec21f
Compare
|
Rebased to fix failing primer tests and added a test as requested. |
Pierre-Sassoulas
requested changes
Apr 6, 2023
Emplis
force-pushed
the
fix-check-unused-args
branch
from
a82ed13 to
0418188
Compare
|
Rebased to include the changelog fragment into the first commit. |
Problem: the special method `__new__` must match the arguments of the `__init__` method even if `__new__` method does not use them. This generate `unused-argument` for the `__new__` method. Fix: the unused arguments check should not be done on the `__new__` method if the `__init__` method is defined in the same class. Fixes pylint-dev#3670
Update `unused-argument` test to include a check for the case of `__init__` and `__new__` being defined in a class but `__new__` does not use all of the argument. This is fine because `__new__` must have the same argument of `__init__`. Update with a second check in case of `__init__` being not defined in a class. Then the unused arguments check must be done on `__new__`.
Emplis
force-pushed
the
fix-check-unused-args
branch
from
3417c49 to
66ee6a6
Compare
Pierre-Sassoulas
approved these changes
Apr 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Problem: the special method `__new__` must match the arguments of the `__init__` method even if `__new__` method does not use them. This generate `unused-argument` for the `__new__` method. Fix: the unused arguments check should not be done on the `__new__` method if the `__init__` method is defined in the same class. Update `unused-argument` test to include a check for the case of `__init__` and `__new__` being defined in a class but `__new__` does not use all of the argument. This is fine because `__new__` must have the same argument of `__init__`. Update with a second check in case of `__init__` being not defined in a class. Then the unused arguments check must be done on `__new__`. Fixes #3670 (cherry picked from commit 156da64)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Apr 6, 2023
Problem: the special method `__new__` must match the arguments of the `__init__` method even if `__new__` method does not use them. This generate `unused-argument` for the `__new__` method. Fix: the unused arguments check should not be done on the `__new__` method if the `__init__` method is defined in the same class. Update `unused-argument` test to include a check for the case of `__init__` and `__new__` being defined in a class but `__new__` does not use all of the argument. This is fine because `__new__` must have the same argument of `__init__`. Update with a second check in case of `__init__` being not defined in a class. Then the unused arguments check must be done on `__new__`. Fixes #3670 (cherry picked from commit 156da64) Co-authored-by: Théo Battrel <theo.util@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Problem: the special method
__new__must match the arguments of the__init__method even if__new__method does not use them. This generateunused-argumentfor the__new__method.Fix: the unused arguments check should not be done on the
__new__method if the__init__method is defined in the same class.Closes #3670