Don't treat __slots__ as enum member

[Bibo-Joshi]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #6887

[coveralls]

Pull Request Test Coverage Report for Build 2780287184

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.001%) to 95.253%

---

Totals
Change from base Build 2779654616:	0.001%
Covered Lines:	16834
Relevant Lines:	17673

---

💛 - Coveralls

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit e9b8ad2

[mbyrnepr2]

Hi! I think the issue applies to any dunder name; not just __slots__. For example:

class E(Enum):
    __x__ = 'x'

class F(E):
    member = 3

pylint x.py:
x.py:7:0: E0244: Extending inherited Enum class "E" (invalid-enum-extension)

[Bibo-Joshi]

__x__ could be an actual enum member though, right? I guess the question is if non-standard dunder attributes should be treated as enum members or not. Personally I'd say yes.

Another thought that I head is that it might be better to have astroid handle this better directly such that we don't have to apply special casing here …

[Pierre-Sassoulas]

+1 @Bibo-Joshi I did not follow everything here but if a fix can be done in astroid it's better to do it in astroid 👍

[Bibo-Joshi]

All right. I'll try to have a look into it or at least open an issue over at astroid :)

[mbyrnepr2]

__x__ could be an actual enum member though, right? I guess the question is if non-standard dunder attributes should be treated as enum members or not. Personally I'd say yes.

Another thought that I head is that it might be better to have astroid handle this better directly such that we don't have to apply special casing here …

It doesn't look like it. The dunder name does not appear in the members container:

(venv310) Marks-MacBook-Air-2:programming markbyrne$ cat y.py 
from enum import Enum


class E(Enum):
    __x__ = 'x'
    AAA = "aaa"

print(E.__members__)
print(type(E.AAA))
print(type(E.__x__))
(venv310) Marks-MacBook-Air-2:programming markbyrne$ python y.py 
{'AAA': <E.AAA: 'aaa'>}
<enum 'E'>
<class 'str'>

So I think the issue is Astroid is inserting them into members when it shouldn't be.

[Bibo-Joshi]

All right. I'll try to have a look into it or at least open an issue over at astroid :)

Here it is: pylint-dev/astroid#1730. In any case, I guess this PR is superfluous. Closing.

[Pierre-Sassoulas]

Thank you @Bibo-Joshi