Fixes `pylint disable=fixme directives ignored for comments following the last statement in a file
#1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast statement in a file + adding three commented lines in fixme.py
PCManticore
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1681.
It only fixes the problem for directive fixme.
The problem here is that a message is added for commented lines beginning with
#FIXMEor#TODOor#XXXeven if the#pylint disable=fixmeis present.In fact the astroid parser doesn't include the commented lines that are following the last module statement.
Thus the astroid module object can not inform pylint about the directives that are present in those extra lines.
The fix consists in manually anlysing those lines with different regexp and string manipulations.