Skip to content

Fix FP for invalid-name for TypedDicts #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

Fix FP for invalid-name for TypedDicts #10673

merged 3 commits into from
Oct 16, 2025

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Oct 16, 2025

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #10672

@jacobtylerwalls jacobtylerwalls added this to the 4.0.2 milestone Oct 16, 2025
@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/4.0.x labels Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 95.96%. Comparing base (ffb3320) to head (6ca6a9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10673   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         176      176           
  Lines       19525    19525           
=======================================
  Hits        18738    18738           
  Misses        787      787
Files with missing lines Coverage Ξ”
pylint/checkers/base/name_checker/checker.py 98.72% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pierre-Sassoulas
Pierre-Sassoulas previously approved these changes Oct 16, 2025
View reviewed changes
@jacobtylerwalls @Pierre-Sassoulas
Apply suggestion from @Pierre-Sassoulas
7280a71 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@jacobtylerwalls jacobtylerwalls merged commit 4eabe26 into pylint-dev:main Oct 16, 2025
44 checks passed
pylint-backport bot pushed a commit that referenced this pull request Oct 16, 2025
@jacobtylerwalls @pylint-backport
Fix FP for invalid-name for TypedDicts (#10673)
862b106 
(cherry picked from commit 4eabe26)
@pylint-backport pylint-backport bot mentioned this pull request Oct 16, 2025
Merged
jacobtylerwalls added a commit that referenced this pull request Oct 16, 2025
@pylint-backport @jacobtylerwalls
[Backport maintenance/4.0.x] Fix FP for invalid-name for TypedDicts (#…
4c913c0 
…10674)

Fix FP for invalid-name for TypedDicts (#10673)

(cherry picked from commit 4eabe26)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

backport maintenance/4.0.x False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Milestone

4.0.2

Development

Successfully merging this pull request may close these issues.

Starting from pyling 4.0.0 we get C0103 errors on naming for typing typedefs

2 participants

@jacobtylerwalls @Pierre-Sassoulas