Feature: teach astroid about Hypothesis' @st.composite decorator
#820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRMacIver
reviewed
Jul 20, 2020
Zac-HD
force-pushed
the
hypothesis-plugin
branch
from
565040a to
d7a2f9d
Compare
Zac-HD
force-pushed
the
hypothesis-plugin
branch
from
d7a2f9d to
0bb5ae9
Compare
PCManticore
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hypothesis'
@st.compositedecorator removes (ie supplies for the caller) the first argument of the decorated function. This has been a small frustration for many people, and caused a large number of# pylint: disable=no-value-for-parametercomments.Recently, with HypothesisWorks/hypothesis#2498, I personally got annoyed on behalf of our users (and, OK, at being repeatedly asked about it) enough to look up Pylint's plugin system, and a few hours later here we are! I must say it's a very smooth extension API 😄
Imitating the boto3 brain there aren't any tests, but I've confirmed it's working locally - just let me know what if anything else I need to do.