New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer starred expressions in tuple, list, set and dict literals #396

Merged

rogalski merged 7 commits into pylint-dev:master from rogalski:infer_starred

Feb 14, 2017

Contributor

rogalski commented Jan 30, 2017

Just a POC, needs:

Guidance on if it’s a correct way to solve a problem
Extra tests
Docs entries

Aims to solve pylint-dev/pylint#957


          Infer starred expressions in (tuple, list, dict) literals

Just a POC, needs:

1) Guidance on if it’s a correct way to solve a problem
2) Extra tests
3) Docs entries

Aims to solve pylint-dev/pylint#957

coveralls commented Jan 30, 2017 •

edited

Loading

Coverage decreased (-1.9%) to 87.449% when pulling 2106371 on rogalski:infer_starred into d0b5acd on PyCQA:master.

Contributor Author

rogalski commented Jan 30, 2017

Lack of coverage is due to guard except clause not being hit. May be easily improved by adding additional tests.

rogalski mentioned this pull request

Understand starred expression used in string formatting RHS tuple pylint-dev/pylint#1299

Merged

rogalski added 3 commits

February 5, 2017 16:18


          Fix namespace population when wildcard import is used (pylint-dev#397)

9a8eec1

Fix pylint-dev/pylint#1312


          Revert "Fix namespace population when wildcard import is used (pylint…

7dbd9bd

…-dev#397)" (pylint-dev#398)

This reverts commit 3e6ef99.


          Extra tests, raise InferenceError when starred expressions cannot be …

5cc5e5b

…inferred

coveralls commented Feb 5, 2017 •

edited

Loading

Coverage increased (+0.02%) to 89.325% when pulling 5cc5e5b on rogalski:infer_starred into d0b5acd on PyCQA:master.


          Overall improvements in docs, raised exceptions and more

b5b5eaf

coveralls commented Feb 7, 2017

Coverage increased (+0.02%) to 89.325% when pulling b5b5eaf on rogalski:infer_starred into d0b5acd on PyCQA:master.

4 similar comments

coveralls commented Feb 7, 2017

Coverage increased (+0.02%) to 89.325% when pulling b5b5eaf on rogalski:infer_starred into d0b5acd on PyCQA:master.

coveralls commented Feb 7, 2017

Coverage increased (+0.02%) to 89.325% when pulling b5b5eaf on rogalski:infer_starred into d0b5acd on PyCQA:master.

coveralls commented Feb 7, 2017

Coverage increased (+0.02%) to 89.325% when pulling b5b5eaf on rogalski:infer_starred into d0b5acd on PyCQA:master.

coveralls commented Feb 7, 2017

Coverage increased (+0.02%) to 89.325% when pulling b5b5eaf on rogalski:infer_starred into d0b5acd on PyCQA:master.

rogalski added the Needs review 🔍 label

PCManticore reviewed

View reviewed changes

Contributor

PCManticore left a comment

This looks amazing @rogalski. Left just one tiny comment. it would be amazing if you could backport this to 2.0 branch.

astroid/inference.py Outdated



		def infer_map(self, context=None):
		if not any(isinstance(k, nodes.DictUnpack) for k, v in self.items):

Contributor

PCManticore Feb 13, 2017

We don't use v.

rogalski changed the title ~~Infer starred expressions in (tuple, list, dict) literals~~ Infer starred expressions in tuple, list, set and dict literals

rogalski added 2 commits

February 14, 2017 20:02


          Merge branch 'master' into infer_starred

bb218dd


          Rename unused name to underscore

aeac1c1

rogalski merged commit 4e7d9fe into pylint-dev:master

rogalski deleted the infer_starred branch

February 14, 2017 19:32

brycepg pushed a commit to brycepg/astroid that referenced this pull request


          Infer starred expressions in tuple, list, set and dict literals (pyli…

775013a

…nt-dev#396)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review 🔍