Return the FunctionDef node when a call is made to a decorated function.#2965
Draft
mbyrnepr2 wants to merge 2 commits into
Draft
Return the FunctionDef node when a call is made to a decorated function.#2965mbyrnepr2 wants to merge 2 commits into
FunctionDef node when a call is made to a decorated function.#2965mbyrnepr2 wants to merge 2 commits into
Conversation
…nction instead of returning the inferred ``FunctionDef`` node. This prevents ``no-member`` messages in Pylint when a decorated function is called and then is missing expected attributes; Pylint recognizes when a ``FunctionDef`` node has any decorators and suppresses the message. Closes pylint-dev/pylint#10848
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Return the
FunctionDefnode when a call is made to a decorated function.instead of returning the inferred
FunctionDefnode. This preventsno-membermessages in Pylint when a decorated function is called and then is missing expected attributes; Pylint recognizes when aFunctionDefnode has any decorators and suppresses the message (https://github.com/pylint-dev/pylint/blob/main/pylint/checkers/typecheck.py#L1133-L1139)Closes pylint-dev/pylint#10848