Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove future argument from statement() and frame() #2676

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

The future is now 🌐

@jacobtylerwalls jacobtylerwalls added this to the 4.0.0 milestone Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 93.20%. Comparing base (6805fa3) to head (81bf697).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2676   +/-   ##
=======================================
  Coverage   93.19%   93.20%           
=======================================
  Files          93       93           
  Lines       11088    11078   -10     
=======================================
- Hits        10334    10325    -9     
+ Misses        754      753    -1     
Flag Coverage Ξ”
linux 93.09% <100.00%> (+<0.01%) ⬆️
pypy 93.20% <100.00%> (+<0.01%) ⬆️
windows 93.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
astroid/nodes/node_classes.py 94.98% <100.00%> (+0.04%) ⬆️
astroid/nodes/node_ng.py 92.63% <100.00%> (+0.19%) ⬆️
astroid/nodes/scoped_nodes/scoped_nodes.py 93.58% <100.00%> (-0.10%) ⬇️

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@Pierre-Sassoulas Pierre-Sassoulas merged commit d2fa037 into main Feb 2, 2025
20 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the remove-future branch February 2, 2025 19:48
@Pierre-Sassoulas Pierre-Sassoulas changed the title Remove future argument Remove future argument from statement() and frame() Feb 2, 2025
@jacobtylerwalls
Copy link
Member Author

@Pierre-Sassoulas I think it's a good time to do a release of astroid 4.0-alpha1 so we can start merging the pylint PRs to fix tests.

@Pierre-Sassoulas
Copy link
Member

Opened #2677

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 4.0.0, 4.0.0a0 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants