Fix annotations for statement method

[cdce8p]

Description

Statement isn't exported form astroid.nodes (anymore ?). All other annotations were updated to use _base_nodes.Statement. It seems these two were missed.

--
Side note
Any particular reason the base_nodes module should be considered private, i.e. prefixed with _? Probably missed that discussion.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a82d9d9) 92.86% compared to head (f26a645) 92.86%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2366   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          94       94           
  Lines       11072    11072           
=======================================
  Hits        10282    10282           
  Misses        790      790           

Flag	Coverage Δ
linux	92.67% <100.00%> (ø)
pypy	91.00% <100.00%> (ø)
windows	92.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
astroid/filter_statements.py	98.91% <100.00%> (ø)
astroid/nodes/node_ng.py	93.61% <100.00%> (ø)

[jacobtylerwalls]

Daniël proposed it here:

mixins.py isn't included in the init.py of astroid and don't provide much use to anybody without actually using the nodes themselves. So I think we can consider this private API.

[cdce8p]

Daniël proposed it here:

mixins.py isn't included in the init.py of astroid and don't provide much use to anybody without actually using the nodes themselves. So I think we can consider this private API.

Hmm 🤔 Just interesting that we need to import _base_nodes even in pylint. The nodes.Statement issue exists there too. So it's probably not all that private...

[Pierre-Sassoulas]

I agree with @cdce8p if we use the import in pylint it should be public (even if it's only for typing I guess).

[DanielNoord]

I think my main rationale was that it is an implementation detail and ideally should be exported as a Protocol. Making it private gave a bit more flexibility while we were still refactoring the code to become fully typed/type-safe.

However, I burned out quite a bit on trying to fully type astroid as it just seems impossible. I would be okay with making it public, but don't think plugin writers should really need it. It seems private to our "core" library. Not sure how we should indicate it as being so.