Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pylint disables #2175

Merged
merged 2 commits into from
May 12, 2023

Conversation

jacobtylerwalls
Copy link
Member

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2175 (6002c79) into main (2cd9e90) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2175   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          94       94           
  Lines       10800    10800           
=======================================
  Hits        10001    10001           
  Misses        799      799           
Flag Coverage Δ
linux 92.36% <ø> (ø)
pypy 87.53% <ø> (ø)
windows 92.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/decorators.py 85.26% <ø> (ø)
astroid/manager.py 87.77% <ø> (ø)
astroid/nodes/scoped_nodes/scoped_nodes.py 91.93% <ø> (ø)

@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining astroid or the dev workflow label May 12, 2023
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could enable useless-suppression maybe ?

@jacobtylerwalls
Copy link
Member Author

We have! I think the tools are just getting better with all the alphas.

enable=useless-suppression

@Pierre-Sassoulas Pierre-Sassoulas merged commit e1b577a into pylint-dev:main May 12, 2023
@jacobtylerwalls jacobtylerwalls deleted the remove-disables branch May 12, 2023 12:12
jacobtylerwalls added a commit to jacobtylerwalls/astroid that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants