Restore setting a Call as a base for classes from six.with_metaclass()
#2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Bug 🪳
pylint-tested
|
@Pierre-Sassoulas do I remember correctly that you develop on Linux? The failing test passes for me on MacOS, so I'm wondering if there are different wheels for |
|
Does this resolve #1735 as well? |
No, it doesn't. But I haven't worked out what the root issue is there--is it that it should expect |
|
I'm unsure. I'm not familiar with that part of astroid, plus I've never used six. |
Harden support for using enums as metaclasses. Fixes the crash in pylint-dev/pylint#5935 by adopting the check for not-none bases as in ClassDef._inferred_bases without recausing the false positive reported in pylint-dev/pylint#7506, which requires correct bases.
jacobtylerwalls
force-pushed
the
with-metaclass-base-fixes
branch
from
d9b29c5 to
aea9410
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
- Coverage 92.82% 92.82% -0.01%
==========================================
Files 95 95
Lines 11066 11065 -1
==========================================
- Hits 10272 10271 -1
Misses 794 794
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
commented
Mar 13, 2023
| self.assertEqual(inferred.name, "B") | ||
| self.assertIsInstance(inferred.bases[0], nodes.Name) | ||
| self.assertEqual(inferred.bases[0].name, "C") | ||
| self.assertIsInstance(inferred.bases[0], nodes.Call) |
There was a problem hiding this comment.
This change restores the prior results before #1622.
|
Yes, I'm on linux, do you want me to test something ? |
We |
|
I can't reproduce the fail either: |
Pierre-Sassoulas
approved these changes
Mar 26, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
…s` (#2049) Harden support for using enums as metaclasses. Fixes the crash in pylint-dev/pylint#5935 by adopting the check for not-none bases as in ClassDef._inferred_bases without recausing the false positive reported in pylint-dev/pylint#7506, which requires correct bases. (cherry picked from commit b5ebf99)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Mar 26, 2023
…s` (#2049) (#2067) Harden support for using enums as metaclasses. Fixes the crash in pylint-dev/pylint#5935 by adopting the check for not-none bases as in ClassDef._inferred_bases without recausing the false positive reported in pylint-dev/pylint#7506, which requires correct bases. (cherry picked from commit b5ebf99) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Pierre-Sassoulas
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Harden support for using enums as metaclasses with
six.with_metaclass(...)syntax.Fixes the crash in pylint-dev/pylint#5935 by adopting the check for not-none bases as in
ClassDef._inferred_baseswithout recausing the false positive reported in pylint-dev/pylint#7506, which requires having correct bases. Here is the analogous existing code:https://github.com/PyCQA/astroid/blob/91fd7b95fc943676f5aafb2d0ee881c4e167fa04/astroid/nodes/scoped_nodes/scoped_nodes.py#L3001-L3006
Essentially reverts #1622 (Sorry! It was my best understanding at the time, and at least we were trading a crash for a false positive.)
Refs pylint-dev/pylint#5935 (crash: tested here with test_metaclass_generator_hack_enum_base)
Refs pylint-dev/pylint#7506 (false positive: will open a pylint regression test PR shortly)