Skip to content

Create ContextManagerModel and let GeneratorModel inherit #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

Create ContextManagerModel and let GeneratorModel inherit #1810

merged 1 commit into from
Sep 29, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Supersedes #1803 and closes pylint-dev/pylint#7505.

Refs pylint-dev/pylint#2567

Type of Changes

Type
✓ 🐛 Bug fix

@DanielNoord DanielNoord added this to the 2.13.0 milestone Sep 29, 2022
This was referenced Sep 29, 2022
Closed
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3151079909

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.425%
Totals Coverage Status
Change from base Build 3133267883: 0.008%
Covered Lines: 9822
Relevant Lines: 10627
💛 - Coveralls

@DanielNoord DanielNoord mentioned this pull request Sep 29, 2022
Open
clavedeluna
clavedeluna approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@clavedeluna clavedeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! I'm wondering if it should be back ported in 2.12.11 ? At this point releasing 2.13 for it also make sense.

@DanielNoord
Copy link
Collaborator Author

Ideally I'd get two PRs in as well:
#1741 just because we need it in pylint for typing and we tend to slow on releases in astroid.
#1752 as the other two fixes in astroid also deal with importing modules (of course... 😅). So I think it makes sense to have this as well.

But I don't mind releasing without them. We can always release 2.14 if we want to immediately after 😄

@DanielNoord DanielNoord merged commit ac1d9a1 into pylint-dev:main Sep 29, 2022
@DanielNoord DanielNoord deleted the generators branch September 29, 2022 13:13
@clavedeluna clavedeluna mentioned this pull request Nov 30, 2022
Closed
@socketpair
Copy link

In what Astroid version it is fixed ?

@Pierre-Sassoulas
Copy link
Member

Checking the milestone of this issue 2.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@clavedeluna clavedeluna clavedeluna approved these changes

Assignees
No one assigned
Labels
Bug 🪳
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielNoord @coveralls @socketpair @Pierre-Sassoulas @clavedeluna