Upgrade to pylint 2.12 and enable for_any_all checker
#1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickdrozd
commented
Nov 26, 2021
nickdrozd
commented
| Type | |
|---|---|
| ✓ | 🔨 Refactoring |
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
requested changes
Nov 26, 2021
|
Looks like the new version of Pylint triggers a few issues. |
for more information, see https://pre-commit.ci
astroid/mixins.py
Outdated
| @@ -28,6 +28,8 @@ | |||
| class BlockRangeMixIn: | |||
There was a problem hiding this comment.
This mixin is not recognized as one, I'll fix this myself suggestions won't work here.
Pierre-Sassoulas
changed the title
for_any_all checker
DanielNoord
reviewed
Nov 27, 2021
| @@ -448,7 +445,7 @@ def _fixed_source_line(self) -> Optional[int]: | |||
| We need this method since not all nodes have :attr:`lineno` set. | |||
| """ | |||
| line = self.lineno | |||
| _node: Optional[NodeNG] = self | |||
| _node: Optional[NodeNG] = self # pylint: disable = used-before-assignment | |||
There was a problem hiding this comment.
Is this a new false positive?
cdce8p
reviewed
Nov 27, 2021
| @@ -301,6 +301,9 @@ ignored-modules=typed_ast.ast3 | |||
| # (useful for classes with attributes dynamically set). | |||
| ignored-classes=SQLObject | |||
|
|
|||
| # Regex pattern to define which classes are considered mixins. | |||
| mixin-class-rgx=.*Mix[i|I]n | |||
There was a problem hiding this comment.
@Pierre-Sassoulas This will also match Mix|n. It should just be .*Mix[Ii]n.
There was a problem hiding this comment.
😄 Obviously I'm just handing the case with really big "i" using pipe, and did not make a regex mistake at all.
Merged
tushar-deepsource
pushed a commit
to tushar-deepsource/astroid
that referenced
this pull request
Dec 20, 2021
…#1277) * Enable for_any_all check * Upgrade to pylint 2.12 in pre-commit configuration * Fix new Pylint warnings * Upgrade the regex for Mixin Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.