Fix regression introduced by #1186 and add tests #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
Regression
pylint-tested
|
Thanks @DanielNoord 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This is based on @cdce8p's suggestion. This also includes the test files he came up with.
I think we should also reconsider the tests that are currently here. Also the one for #1186. I don't think we actually reached consensus in that issue about whether we are fully testing everything we want. It seems we're missing some knowledge about how
astroidresourcesare tested.I did test this with pylint-dev/pylint#5059 and this suggestion works.
Type of Changes
Related Issue
This closes #1200