Skip to content

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Aug 20, 2025

I got annoyed by all the warnings of not found links by mkdocs due to the hacky logbook links. So now we have different hacky logbook links, about which mkdocs will not complain!
Bonus: they are a few characters shorter than the old ones!

Bonus Bonus: The 2022 LHC links are now also in the proper format (I had Gemini do that, though)

@JoschD JoschD requested review from fsoubelet and jgray-19 August 20, 2025 18:10
@JoschD JoschD self-assigned this Aug 20, 2025
@JoschD JoschD added Type: Documentation Improvements, updates and fixes to the documentation. Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Medium Work on this. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. labels Aug 20, 2025
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative diff PR, must be my birthday. Wonderful

Copy link
Contributor

@jgray-19 jgray-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand it but the links work for me so lgtm.

@JoschD JoschD merged commit 6052b6e into master Aug 21, 2025
2 checks passed
@JoschD JoschD deleted the better_logbook_links branch August 21, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Medium Work on this. Type: Documentation Improvements, updates and fixes to the documentation. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants