Skip to content

Conversation

@samwaseda
Copy link
Member

@samwaseda samwaseda commented Mar 3, 2025

I removed the wave parser because it was not tested. Also I remove cwd because it was never used. Add more tests for the output parser.

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Binder 👈 Launch a binder notebook on branch pyiron/sphinx_parser/tests

@codacy-production
Copy link

codacy-production bot commented Mar 3, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+5.18% (target: -1.00%) 83.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3210187) 966 808 83.64%
Head commit (f6a46f3) 886 (-80) 787 (-21) 88.83% (+5.18%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#38) 18 15 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Mar 3, 2025

Pull Request Test Coverage Report for Build 13627144747

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.2%) to 88.826%

Files with Coverage Reduction New Missed Lines %
output.py 31 81.04%
Totals Coverage Status
Change from base Build 13626471415: 5.2%
Covered Lines: 787
Relevant Lines: 886

💛 - Coveralls

@samwaseda samwaseda changed the title [patch] Add tests [patch] Remove wave parser and cwd Mar 3, 2025
@samwaseda samwaseda merged commit 5ed6b70 into main Mar 3, 2025
18 checks passed
@samwaseda samwaseda deleted the tests branch March 3, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants