Skip to content

Fix integration notebooks#1291

Merged
jan-janssen merged 7 commits intomainfrom
jan-janssen-patch-1
Jan 12, 2024
Merged

Fix integration notebooks#1291
jan-janssen merged 7 commits intomainfrom
jan-janssen-patch-1

Conversation

@jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen added the integration Start the notebook integration tests for this PR label Jan 12, 2024
@coveralls
Copy link

coveralls commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7505504666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.436%

Totals Coverage Status
Change from base Build 7489188383: 0.0%
Covered Lines: 24775
Relevant Lines: 30801

💛 - Coveralls

@jan-janssen
Copy link
Member Author

CalledProcessError: Command '/usr/share/miniconda3/envs/my-env/share/pyiron/lammps/bin/run_lammps_2020.03.03.sh' returned non-zero exit status 1.

@jan-janssen
Copy link
Member Author

The code that fails seems to be:

job = pr.create.job.Lammps("test_ni", delete_existing_job=True)
job.structure = water
job.potential = water_potential
job.calc_static()
job.run()

@jan-janssen
Copy link
Member Author

@jan-janssen jan-janssen marked this pull request as draft January 12, 2024 08:16
@jan-janssen
Copy link
Member Author

This bug is hopefully fixed by pyiron/pyiron_base#1284

@jan-janssen jan-janssen reopened this Jan 12, 2024
@jan-janssen jan-janssen marked this pull request as ready for review January 12, 2024 17:33
@jan-janssen jan-janssen merged commit 558f33b into main Jan 12, 2024
@jan-janssen jan-janssen deleted the jan-janssen-patch-1 branch January 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration Start the notebook integration tests for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants